devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mohammad Rasim <mohammad.rasim96@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
Date: Mon, 2 Dec 2019 11:02:03 +0300	[thread overview]
Message-ID: <20191202080203.js5fciajlf7qkgvw@manjaro.localdomain> (raw)
In-Reply-To: <CAFBinCCYzThAM_DkQyDZ2LrF-6bJoxeNZDtfADmWOxLH+B3AUw@mail.gmail.com>

On 19/12/01 11:21PM, Martin Blumenstingl wrote:
> [...]
> > +       leds {
> > +               compatible = "gpio-leds";
> > +               status {
> > +                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> > +                       default-state = "off";
> > +                       color = <LED_COLOR_ID_RED>;
> > +                       function = LED_FUNCTION_STATUS;
> why is LED_FUNCTION_STATUS not enclosed in <> like color above?
>
Well, the examples in the documentation enclose the color and don't
enclose function
https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140

Regards
>
> Martin

  reply	other threads:[~2019-12-02  8:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191130195335.17740-1-mohammad.rasim96@gmail.com>
2019-11-30 19:53 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings Mohammad Rasim
2019-12-01 22:20   ` Martin Blumenstingl
2019-11-30 19:53 ` [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-12-01 22:21   ` Martin Blumenstingl
2019-12-02  8:02     ` Mohammad Rasim [this message]
2019-12-03 20:58       ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202080203.js5fciajlf7qkgvw@manjaro.localdomain \
    --to=mohammad.rasim96@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).