devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties
@ 2019-11-25  9:27 Eugen.Hristev
  2019-12-02 17:36 ` Alexandre Belloni
  0 siblings, 1 reply; 3+ messages in thread
From: Eugen.Hristev @ 2019-11-25  9:27 UTC (permalink / raw)
  To: alexandre.belloni, Ludovic.Desroches, robh+dt
  Cc: Nicolas.Ferre, linux-arm-kernel, devicetree, linux-kernel, Eugen.Hristev

From: Eugen Hristev <eugen.hristev@microchip.com>

Add properties for i2c filters for i2c0 and i2c1 on sama5d27_som1_ek.
Noise is affecting communication on i2c for example when connecting i2c
camera sensors.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index fca5716..b6a22bb 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -123,6 +123,9 @@
 
 			flx1: flexcom@f8038000 {
 				atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
+				i2c-analog-filter;
+				i2c-digital-filter;
+				i2c-digital-filter-width-ns = <35>;
 				status = "okay";
 
 				i2c2: i2c@600 {
@@ -246,6 +249,9 @@
 
 			i2c1: i2c@fc028000 {
 				dmas = <0>, <0>;
+				i2c-analog-filter;
+				i2c-digital-filter;
+				i2c-digital-filter-width-ns = <35>;
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_i2c1_default>;
 				status = "okay";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties
  2019-11-25  9:27 [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties Eugen.Hristev
@ 2019-12-02 17:36 ` Alexandre Belloni
  2019-12-05  7:45   ` Eugen.Hristev
  0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2019-12-02 17:36 UTC (permalink / raw)
  To: Eugen.Hristev
  Cc: Ludovic.Desroches, robh+dt, Nicolas.Ferre, linux-arm-kernel,
	devicetree, linux-kernel

On 25/11/2019 09:27:41+0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> Add properties for i2c filters for i2c0 and i2c1 on sama5d27_som1_ek.
> Noise is affecting communication on i2c for example when connecting i2c
> camera sensors.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties
  2019-12-02 17:36 ` Alexandre Belloni
@ 2019-12-05  7:45   ` Eugen.Hristev
  0 siblings, 0 replies; 3+ messages in thread
From: Eugen.Hristev @ 2019-12-05  7:45 UTC (permalink / raw)
  To: alexandre.belloni
  Cc: devicetree, linux-kernel, Ludovic.Desroches, robh+dt, linux-arm-kernel



On 02.12.2019 19:36, Alexandre Belloni wrote:

> On 25/11/2019 09:27:41+0000, Eugen.Hristev@microchip.com wrote:
>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Add properties for i2c filters for i2c0 and i2c1 on sama5d27_som1_ek.
>> Noise is affecting communication on i2c for example when connecting i2c
>> camera sensors.
>>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>> ---
>>   arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
> Applied, thanks.

Hi Alexandre,

The properties for i2c0 are at the wrong node. Should be at the child 
node. I sent a v2 to correct it. If it's too late let me know and I can 
make a fix patch instead.

Thanks and sorry,
Eugen

> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-05  7:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25  9:27 [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties Eugen.Hristev
2019-12-02 17:36 ` Alexandre Belloni
2019-12-05  7:45   ` Eugen.Hristev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).