From: Mark Brown <broonie@kernel.org>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: kernel@puri.sm, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Enrico Weigelt <info@metux.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sound: codecs: gtm601: add Broadmobi bm818 sound profile
Date: Tue, 3 Dec 2019 14:32:03 +0000 [thread overview]
Message-ID: <20191203143203.GK1998@sirena.org.uk> (raw)
In-Reply-To: <20191202174831.13638-2-angus@akkea.ca>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Mon, Dec 02, 2019 at 10:48:30AM -0700, Angus Ainslie (Purism) wrote:
> + if (np && of_device_is_compatible(np, "broadmobi,bm818"))
> + dai_driver = &bm818_dai;
Rather than having a tree of these it'd be better if...
> #if defined(CONFIG_OF)
> static const struct of_device_id gtm601_codec_of_match[] = {
> { .compatible = "option,gtm601", },
> + { .compatible = "broadmobi,bm818", },
> {},
> };
...this used the data you can provide along with the of_match as
the dai_driver so the probe function doesn't have to know about
the individual variants.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-12-03 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 17:48 [PATCH 0/2] Add the broadmobi BM818 Angus Ainslie (Purism)
2019-12-02 17:48 ` [PATCH 1/2] sound: codecs: gtm601: add Broadmobi bm818 sound profile Angus Ainslie (Purism)
2019-12-03 14:32 ` Mark Brown [this message]
2019-12-02 17:48 ` [PATCH 2/2] ASoC: gtm601: add the broadmobi interface Angus Ainslie (Purism)
2019-12-13 23:30 ` Rob Herring
2019-12-03 14:27 ` [PATCH 0/2] Add the broadmobi BM818 Mark Brown
2019-12-03 14:34 ` Angus Ainslie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203143203.GK1998@sirena.org.uk \
--to=broonie@kernel.org \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=info@metux.net \
--cc=kernel@puri.sm \
--cc=kstewart@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).