* [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant
[not found] <1574465484-7115-1-git-send-email-jcrouse@codeaurora.org>
@ 2019-11-22 23:31 ` Jordan Crouse
2019-12-03 19:14 ` Rob Herring
2019-11-22 23:32 ` [PATCH v2 8/8] arm64: dts: qcom: sdm845: Update Adreno GPU SMMU compatible string Jordan Crouse
[not found] ` <0101016e95751c0b-33c9379b-6b8c-43b1-8785-e5e1b6f084f1-000000@us-west-2.amazonses.com>
2 siblings, 1 reply; 5+ messages in thread
From: Jordan Crouse @ 2019-11-22 23:31 UTC (permalink / raw)
To: iommu
Cc: robin.murphy, will, linux-arm-kernel, linux-arm-msm, devicetree,
linux-kernel, Rob Herring, Mark Rutland, Joerg Roedel
Add a compatible string to identify SMMUs that are attached
to Adreno GPU devices that wish to support split pagetables.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---
Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 6515dbe..db9f826 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -31,6 +31,12 @@ properties:
- qcom,sdm845-smmu-v2
- const: qcom,smmu-v2
+ - description: Qcom Adreno GPU SMMU iplementing split pagetables
+ items:
+ - enum:
+ - qcom,adreno-smmu-v2
+ - const: qcom,smmu-v2
+
- description: Qcom SoCs implementing "arm,mmu-500"
items:
- enum:
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 8/8] arm64: dts: qcom: sdm845: Update Adreno GPU SMMU compatible string
[not found] <1574465484-7115-1-git-send-email-jcrouse@codeaurora.org>
2019-11-22 23:31 ` [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant Jordan Crouse
@ 2019-11-22 23:32 ` Jordan Crouse
[not found] ` <0101016e95751c0b-33c9379b-6b8c-43b1-8785-e5e1b6f084f1-000000@us-west-2.amazonses.com>
2 siblings, 0 replies; 5+ messages in thread
From: Jordan Crouse @ 2019-11-22 23:32 UTC (permalink / raw)
To: iommu
Cc: robin.murphy, will, linux-arm-kernel, linux-arm-msm, devicetree,
Bjorn Andersson, linux-kernel, Andy Gross, Rob Herring,
Mark Rutland
Add "qcom,adreno-smmu-v2" compatible string for the Adreno GPU SMMU node
to enable split pagetable support.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index ddb1f23..d90ba6eda 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2869,7 +2869,7 @@
};
adreno_smmu: iommu@5040000 {
- compatible = "qcom,sdm845-smmu-v2", "qcom,smmu-v2";
+ compatible = "qcom,adreno-smmu-v2", "qcom,smmu-v2";
reg = <0 0x5040000 0 0x10000>;
#iommu-cells = <1>;
#global-interrupts = <2>;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant
2019-11-22 23:31 ` [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant Jordan Crouse
@ 2019-12-03 19:14 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-12-03 19:14 UTC (permalink / raw)
To: Jordan Crouse
Cc: iommu, robin.murphy, will, linux-arm-kernel, linux-arm-msm,
devicetree, linux-kernel, Mark Rutland, Joerg Roedel
On Fri, Nov 22, 2019 at 11:31:51PM +0000, Jordan Crouse wrote:
> Add a compatible string to identify SMMUs that are attached
> to Adreno GPU devices that wish to support split pagetables.
>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
>
> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant
[not found] ` <0101016e95751c0b-33c9379b-6b8c-43b1-8785-e5e1b6f084f1-000000@us-west-2.amazonses.com>
@ 2019-12-04 15:55 ` Robin Murphy
2019-12-04 18:01 ` Rob Clark
0 siblings, 1 reply; 5+ messages in thread
From: Robin Murphy @ 2019-12-04 15:55 UTC (permalink / raw)
To: Jordan Crouse, iommu
Cc: will, linux-arm-kernel, linux-arm-msm, devicetree, linux-kernel,
Rob Herring, Mark Rutland, Joerg Roedel
On 22/11/2019 11:31 pm, Jordan Crouse wrote:
> Add a compatible string to identify SMMUs that are attached
> to Adreno GPU devices that wish to support split pagetables.
A software policy decision is not, in itself, a good justification for a
DT property. Is the GPU SMMU fundamentally different in hardware* from
the other SMMU(s) in any given SoC?
(* where "hardware" may encompass hypervisor shenanigans)
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
>
> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 6515dbe..db9f826 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -31,6 +31,12 @@ properties:
> - qcom,sdm845-smmu-v2
> - const: qcom,smmu-v2
>
> + - description: Qcom Adreno GPU SMMU iplementing split pagetables
> + items:
> + - enum:
> + - qcom,adreno-smmu-v2
> + - const: qcom,smmu-v2
Given that we already have per-SoC compatibles for Qcom SMMUs in
general, this seems suspiciously vague.
Robin.
> +
> - description: Qcom SoCs implementing "arm,mmu-500"
> items:
> - enum:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant
2019-12-04 15:55 ` [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant Robin Murphy
@ 2019-12-04 18:01 ` Rob Clark
0 siblings, 0 replies; 5+ messages in thread
From: Rob Clark @ 2019-12-04 18:01 UTC (permalink / raw)
To: Robin Murphy
Cc: Jordan Crouse,
list@263.net:IOMMU DRIVERS
<iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, Linux Kernel Mailing List, Rob Herring,
Will Deacon,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Wed, Dec 4, 2019 at 7:56 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 22/11/2019 11:31 pm, Jordan Crouse wrote:
> > Add a compatible string to identify SMMUs that are attached
> > to Adreno GPU devices that wish to support split pagetables.
>
> A software policy decision is not, in itself, a good justification for a
> DT property. Is the GPU SMMU fundamentally different in hardware* from
> the other SMMU(s) in any given SoC?
The GPU CP has some sort of mechanism to switch pagetables.. although
I guess under the firmware it is all the same. Jordan should know
better..
BR,
-R
> (* where "hardware" may encompass hypervisor shenanigans)
>
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > ---
> >
> > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > index 6515dbe..db9f826 100644
> > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > @@ -31,6 +31,12 @@ properties:
> > - qcom,sdm845-smmu-v2
> > - const: qcom,smmu-v2
> >
> > + - description: Qcom Adreno GPU SMMU iplementing split pagetables
> > + items:
> > + - enum:
> > + - qcom,adreno-smmu-v2
> > + - const: qcom,smmu-v2
>
> Given that we already have per-SoC compatibles for Qcom SMMUs in
> general, this seems suspiciously vague.
>
> Robin.
>
> > +
> > - description: Qcom SoCs implementing "arm,mmu-500"
> > items:
> > - enum:
> >
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-04 18:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1574465484-7115-1-git-send-email-jcrouse@codeaurora.org>
2019-11-22 23:31 ` [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant Jordan Crouse
2019-12-03 19:14 ` Rob Herring
2019-11-22 23:32 ` [PATCH v2 8/8] arm64: dts: qcom: sdm845: Update Adreno GPU SMMU compatible string Jordan Crouse
[not found] ` <0101016e95751c0b-33c9379b-6b8c-43b1-8785-e5e1b6f084f1-000000@us-west-2.amazonses.com>
2019-12-04 15:55 ` [PATCH v2 1/8] dt-bindings: arm-smmu: Add Adreno GPU variant Robin Murphy
2019-12-04 18:01 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).