From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2188C43603 for ; Wed, 4 Dec 2019 12:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7554020803 for ; Wed, 4 Dec 2019 12:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575463017; bh=IEViihsXqnNjLA7qY7TBVTr1iIuoipkvM1Y0xCsQOiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GR5ouROv1Ne8e312+J2vESWbtjyTpW5/1ZzG/1OryRUQjVTrhaakaImDfB4eQt8Jx bQ2SV3aAr2eO+cwT0xZmGve0cPqj1E9ysB0dVGT0BwkC2q04UgfZsjv6EuS1T+yySC R4KcvXiOKEc9ekSauRq0Drll1ZOYzI6EJbNR78qU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbfLDMg4 (ORCPT ); Wed, 4 Dec 2019 07:36:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:34480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbfLDMg4 (ORCPT ); Wed, 4 Dec 2019 07:36:56 -0500 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1B172077B; Wed, 4 Dec 2019 12:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575463016; bh=IEViihsXqnNjLA7qY7TBVTr1iIuoipkvM1Y0xCsQOiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NixFrMHiAyrafH7vOuLQuynqWv63B7yq3UGMsHHw3XdazZbYIrxadrALygMKPK7VA Ap9Vi4rdWr4bsQhrqb1XggvkMLG2RfJTwv+DQv+gNn/Lhn6jpmmToAXlwMFW0ZYA7s 76P2lngyF3sWm+mvDEBj1dTFt32rr2QooPwkWdNY= Date: Wed, 4 Dec 2019 20:36:47 +0800 From: Shawn Guo To: Andreas Kemnade Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "H . Nikolaus Schaller" Subject: Re: [PATCH] ARM: dts: e60k02: fix power button Message-ID: <20191204123645.GL3365@dragon> References: <20191111202959.24189-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111202959.24189-1-andreas@kemnade.info> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 11, 2019 at 09:29:59PM +0100, Andreas Kemnade wrote: > The power button was only producing irqs, but no key events, > Forced power down with long key press works, so probably > only a short spike arrives at the SoC. > Further investigation shows that LDORTC2 is off after boot > of the vendor kernel. LDORTC2 is shared with a GPIO at the pmic > which probably transfers the button press to the SoC. > That regulator off at boot, so "regulator-boot-on" is definitively > wrong. So remove that. > > Reported-by: H. Nikolaus Schaller > Signed-off-by: Andreas Kemnade Do you want this go into 5.5-rc as a fix? In that case, we may need a Fixes tag here. Shawn > --- > arch/arm/boot/dts/e60k02.dtsi | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi > index a0ade2ba7a21..33e02bd2b59d 100644 > --- a/arch/arm/boot/dts/e60k02.dtsi > +++ b/arch/arm/boot/dts/e60k02.dtsi > @@ -356,11 +356,6 @@ > regulator-name = "LDORTC1"; > regulator-boot-on; > }; > - > - ldortc2_reg: LDORTC2 { > - regulator-name = "LDORTC2"; > - regulator-boot-on; > - }; > }; > }; > }; > -- > 2.20.1 >