From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2526C43603 for ; Fri, 6 Dec 2019 15:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A29FC2464E for ; Fri, 6 Dec 2019 15:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbfLFPwy convert rfc822-to-8bit (ORCPT ); Fri, 6 Dec 2019 10:52:54 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52199 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbfLFPwy (ORCPT ); Fri, 6 Dec 2019 10:52:54 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 15AF0E0015; Fri, 6 Dec 2019 15:52:51 +0000 (UTC) Date: Fri, 6 Dec 2019 16:52:50 +0100 From: Miquel Raynal To: Heiko Stuebner Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Paul Kocialkowski , Maxime Chevallier , Thomas Petazzoni Subject: Re: [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity Message-ID: <20191206165250.5877dec8@xps13> In-Reply-To: <3285991.EbEXlA3CnX@phil> References: <20191206154247.28057-1-miquel.raynal@bootlin.com> <3285991.EbEXlA3CnX@phil> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Heiko, Heiko Stuebner wrote on Fri, 06 Dec 2019 16:48:00 +0100: > Hi Miquel, > > Am Freitag, 6. Dezember 2019, 16:42:47 CET schrieb Miquel Raynal: > > PMIC interrupt can be active high or active low depending on BIT(1) of > > the GPIO_INT_CFG pin. The default is 0x1, which means active > > high. Change the polarity in the device tree to reflect the default > > state. > > > > Without this and with the current code base, the interrupt never stops > > triggering while the MFD driver does not see anything to > > check/clear/mask so after 100000 spurious IRQs, the kernel simply > > desactivates the interrupt: > > > > irq 36: nobody cared (try booting with the "irqpoll" option) > > [...] > > handlers: > > [<(____ptrval____)>] irq_default_primary_handler threaded > > [<(____ptrval____)>] regmap_irq_thread > > Disabling IRQ #36 > > > > Signed-off-by: Miquel Raynal > > *coughs slightly* > > mfd: rk808: Set RK817 interrupt polarity to low > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/drivers/mfd/rk808.c?h=for-mfd-next&id=dbd16ef53487084816a20f662423ab543a75fc83 > > Should be in the current merge window already I guess ;-) This time I swear I checked your tree. But this time we did not ended with the same fix so I missed this one *again* :) > > Having this consistent over all rk8xx seemed nicer. I'm fine with this approach too. Thanks, Miquèl