From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760C4C43603 for ; Mon, 9 Dec 2019 00:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B976206DB for ; Mon, 9 Dec 2019 00:54:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="h7AuxBaB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbfLIAyh (ORCPT ); Sun, 8 Dec 2019 19:54:37 -0500 Received: from onstation.org ([52.200.56.107]:37092 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbfLIAyh (ORCPT ); Sun, 8 Dec 2019 19:54:37 -0500 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 68F983E995; Mon, 9 Dec 2019 00:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1575852876; bh=dGqyMsBDrjQ3UdfK1DQX10vVAD15A+SKxZss7KlSu8M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h7AuxBaB5JPI1qheJo50SFsN2MviAWGUESZ7PpykmcfMNvvhnSolh+oUw1MiElcxr ezki8sak4GRO0UF6Bz5RGhcRNTmrvTXS6YDFqhYprO+geG5oaKA7KPze3Y5a7QjgaE HVtZmJnXTNqGIg8u9b9SHAsVZs36q42UCsBbclYw= Date: Sun, 8 Dec 2019 19:54:36 -0500 From: Brian Masney To: Rob Herring Cc: Stephen Boyd , Dmitry Torokhov , Mark Rutland , Andy Gross , Bjorn Andersson , Michael Turquette , Linux Input , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-msm , linux-clk Subject: Re: [PATCH 4/7] dt-bindings: Input: introduce new clock vibrator bindings Message-ID: <20191209005436.GA13647@onstation.org> References: <20191205002503.13088-1-masneyb@onstation.org> <20191205002503.13088-5-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 05, 2019 at 07:56:10AM -0600, Rob Herring wrote: > On Wed, Dec 4, 2019 at 6:25 PM Brian Masney wrote: > > > > Add support for clock-based vibrator devices where the speed can be > > controlled by changing the duty cycle. > > > > Signed-off-by: Brian Masney > > --- > > .../bindings/input/clk-vibrator.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/clk-vibrator.yaml b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > new file mode 100644 > > index 000000000000..2103a5694fad > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > @@ -0,0 +1,60 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/bindings/input/clk-vibrator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Clock vibrator > > + > > +maintainers: > > + - Brian Masney > > + > > +description: | > > + Support for clock-based vibrator devices where the speed can be controlled > > + by changing the duty cycle. > > + > > +properties: > > + compatible: > > + const: clk-vibrator > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + description: output clock that controls the speed > > + items: > > + - const: core > > No point in making up a name when there's only one clock, so drop. OK, will do. > > > + > > + clock-frequency: true > > Given the frequency is variable, what does this mean in this case? The clock frequency is fixed. The duty cycle is what's variable. Brian > > > + enable-gpios: > > + maxItems: 1 > > + > > + vcc-supply: > > + description: Regulator that provides power > > + > > +required: > > + - compatible > > + - clocks > > + - clock-names > > + - clock-frequency > > Add: > > additionalProperties: false > > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + vibrator { > > + compatible = "clk-vibrator"; > > + > > + vcc-supply = <&pm8941_l19>; > > + > > + clocks = <&mmcc CAMSS_GP1_CLK>; > > + clock-names = "core"; > > + clock-frequency = <24000>; > > + > > + enable-gpios = <&msmgpio 60 GPIO_ACTIVE_HIGH>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&vibrator_pin>; > > + }; > > -- > > 2.21.0 > >