From: Maxime Ripard <mripard@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wens@csie.org,
alistair23@gmail.com
Subject: Re: [PATCH] arm64: allwinner: Enable Bluetooth and WiFi on sopine baseboard
Date: Mon, 9 Dec 2019 20:37:29 +0100 [thread overview]
Message-ID: <20191209193729.jfw2z4iqlhrzohse@hendrix.lan> (raw)
In-Reply-To: <20191207192249.8346-1-alistair@alistair23.me>
On Sat, Dec 07, 2019 at 11:22:49AM -0800, Alistair Francis wrote:
> The sopine board has an optional RTL8723BS WiFi + BT module that can be
> connected to UART1. Add this to the device tree so that it will work for
> users if connected.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index 920103ec0046..0a91f9d8ed47 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -214,6 +214,20 @@ &uart0 {
> status = "okay";
> };
>
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> + status = "okay";
> +
> + bluetooth {
> + compatible = "realtek,rtl8723bs-bt";
> + reset-gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */
> + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
> + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> + firmware-postfix = "pine64";
> + };
> +};
> +
Output from checkpatch:
total: 10 errors, 11 warnings, 0 checks, 20 lines checked
More importantly, that binding isn't documented, and doesn't have a
driver either.
I guess you want to have a look at:
https://www.spinics.net/lists/arm-kernel/msg771488.html
Maxime
next prev parent reply other threads:[~2019-12-09 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 19:22 [PATCH] arm64: allwinner: Enable Bluetooth and WiFi on sopine baseboard Alistair Francis
2019-12-09 19:37 ` Maxime Ripard [this message]
2019-12-10 0:56 ` Alistair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209193729.jfw2z4iqlhrzohse@hendrix.lan \
--to=mripard@kernel.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).