devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
@ 2019-12-03 13:03 Martin Kepplinger
  2019-12-10  9:08 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer Martin Kepplinger
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Martin Kepplinger @ 2019-12-03 13:03 UTC (permalink / raw)
  To: robh, mark.rutland
  Cc: kernel, linux-imx, kernel, devicetree, linux-arm-kernel,
	linux-kernel, Martin Kepplinger

Now that there is driver support, describe the accel and gyro sensor parts
of the LSM9DS1 IMU.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 683a11035643..7a92704c53ec 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -415,6 +415,13 @@
 	pinctrl-0 = <&pinctrl_i2c3>;
 	status = "okay";
 
+	accel_gyro@6a {
+		compatible = "st,lsm9ds1-imu";
+		reg = <0x6a>;
+		vdd-supply = <&reg_3v3_p>;
+		vddio-supply = <&reg_3v3_p>;
+	};
+
 	magnetometer@1e	{
 		compatible = "st,lsm9ds1-magn";
 		reg = <0x1e>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer
  2019-12-03 13:03 [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
@ 2019-12-10  9:08 ` Martin Kepplinger
  2019-12-16  9:32 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
  2019-12-16 16:27 ` Guido Günther
  2 siblings, 0 replies; 6+ messages in thread
From: Martin Kepplinger @ 2019-12-10  9:08 UTC (permalink / raw)
  To: robh, mark.rutland
  Cc: kernel, linux-imx, kernel, devicetree, linux-arm-kernel,
	linux-kernel, Angus Ainslie (Purism),
	Martin Kepplinger

From: "Angus Ainslie (Purism)" <angus@akkea.ca>

The LSM9DS1 uses a high level interrupt.

Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---

Any objections or questions about the previously sent accelerometer DT
description? It and this follow-up bugfix is what we're running for
quite some time now.

thanks,

                             martin



 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 2834d273bfdf..8de24a2d5234 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -429,7 +429,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_imu>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
 		vdd-supply = <&reg_3v3_p>;
 		vddio-supply = <&reg_3v3_p>;
 	};
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
  2019-12-03 13:03 [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
  2019-12-10  9:08 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer Martin Kepplinger
@ 2019-12-16  9:32 ` Martin Kepplinger
  2019-12-23  7:18   ` Shawn Guo
  2019-12-16 16:27 ` Guido Günther
  2 siblings, 1 reply; 6+ messages in thread
From: Martin Kepplinger @ 2019-12-16  9:32 UTC (permalink / raw)
  To: robh, mark.rutland
  Cc: kernel, linux-imx, kernel, devicetree, linux-arm-kernel,
	linux-kernel, Rob Herring, Shawn Guo

On 03.12.19 14:03, Martin Kepplinger wrote:
> Now that there is driver support, describe the accel and gyro sensor parts
> of the LSM9DS1 IMU.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 683a11035643..7a92704c53ec 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -415,6 +415,13 @@
>  	pinctrl-0 = <&pinctrl_i2c3>;
>  	status = "okay";
>  
> +	accel_gyro@6a {
> +		compatible = "st,lsm9ds1-imu";
> +		reg = <0x6a>;
> +		vdd-supply = <&reg_3v3_p>;
> +		vddio-supply = <&reg_3v3_p>;
> +	};
> +
>  	magnetometer@1e	{
>  		compatible = "st,lsm9ds1-magn";
>  		reg = <0x1e>;
> 

(adding / fixing people in CC)

Are there any questions about this addition or the followup fix?

thanks a lot,

                               martin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
  2019-12-03 13:03 [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
  2019-12-10  9:08 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer Martin Kepplinger
  2019-12-16  9:32 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
@ 2019-12-16 16:27 ` Guido Günther
  2 siblings, 0 replies; 6+ messages in thread
From: Guido Günther @ 2019-12-16 16:27 UTC (permalink / raw)
  To: Martin Kepplinger
  Cc: robh, mark.rutland, devicetree, kernel, linux-kernel, linux-imx,
	kernel, linux-arm-kernel

Hi,
On Tue, Dec 03, 2019 at 02:03:36PM +0100, Martin Kepplinger wrote:
> Now that there is driver support, describe the accel and gyro sensor parts
> of the LSM9DS1 IMU.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 683a11035643..7a92704c53ec 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -415,6 +415,13 @@
>  	pinctrl-0 = <&pinctrl_i2c3>;
>  	status = "okay";
>  
> +	accel_gyro@6a {
> +		compatible = "st,lsm9ds1-imu";
> +		reg = <0x6a>;
> +		vdd-supply = <&reg_3v3_p>;
> +		vddio-supply = <&reg_3v3_p>;
> +	};
> +

Reviewed-by: Guido Günther <agx@sigxcpu.org>
 -- Guido

>  	magnetometer@1e	{
>  		compatible = "st,lsm9ds1-magn";
>  		reg = <0x1e>;
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
  2019-12-16  9:32 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
@ 2019-12-23  7:18   ` Shawn Guo
  2019-12-23  8:13     ` Martin Kepplinger
  0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2019-12-23  7:18 UTC (permalink / raw)
  To: Martin Kepplinger
  Cc: robh, mark.rutland, kernel, linux-imx, kernel, devicetree,
	linux-arm-kernel, linux-kernel

On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
> On 03.12.19 14:03, Martin Kepplinger wrote:
> > Now that there is driver support, describe the accel and gyro sensor parts
> > of the LSM9DS1 IMU.
> > 
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..7a92704c53ec 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -415,6 +415,13 @@
> >  	pinctrl-0 = <&pinctrl_i2c3>;
> >  	status = "okay";
> >  
> > +	accel_gyro@6a {

We prefer to use hyphen than underscore in node name.  Also nodes with
unit-address should be sorted in the address.

Shawn

> > +		compatible = "st,lsm9ds1-imu";
> > +		reg = <0x6a>;
> > +		vdd-supply = <&reg_3v3_p>;
> > +		vddio-supply = <&reg_3v3_p>;
> > +	};
> > +
> >  	magnetometer@1e	{
> >  		compatible = "st,lsm9ds1-magn";
> >  		reg = <0x1e>;
> > 
> 
> (adding / fixing people in CC)
> 
> Are there any questions about this addition or the followup fix?
> 
> thanks a lot,
> 
>                                martin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
  2019-12-23  7:18   ` Shawn Guo
@ 2019-12-23  8:13     ` Martin Kepplinger
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Kepplinger @ 2019-12-23  8:13 UTC (permalink / raw)
  To: Shawn Guo, Martin Kepplinger
  Cc: robh, mark.rutland, kernel, linux-imx, kernel, devicetree,
	linux-arm-kernel, linux-kernel



On 23.12.19 08:18, Shawn Guo wrote:
> On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
>> On 03.12.19 14:03, Martin Kepplinger wrote:
>>> Now that there is driver support, describe the accel and gyro sensor parts
>>> of the LSM9DS1 IMU.
>>>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>>> ---
>>>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> index 683a11035643..7a92704c53ec 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> @@ -415,6 +415,13 @@
>>>  	pinctrl-0 = <&pinctrl_i2c3>;
>>>  	status = "okay";
>>>  
>>> +	accel_gyro@6a {
> 
> We prefer to use hyphen than underscore in node name.  Also nodes with
> unit-address should be sorted in the address.
> 
> Shawn

thanks a lot for taking a look. resent.

                               martin


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-23  8:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 13:03 [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
2019-12-10  9:08 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer Martin Kepplinger
2019-12-16  9:32 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
2019-12-23  7:18   ` Shawn Guo
2019-12-23  8:13     ` Martin Kepplinger
2019-12-16 16:27 ` Guido Günther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).