From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88860C43603 for ; Wed, 11 Dec 2019 19:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 580F721556 for ; Wed, 11 Dec 2019 19:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0/wx5BRx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727494AbfLKT1P (ORCPT ); Wed, 11 Dec 2019 14:27:15 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:48686 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfLKT1O (ORCPT ); Wed, 11 Dec 2019 14:27:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fhhzlnh0YMGIMRykWTm4rFFLUMRsYVi5NX6Vsu+Wz9k=; b=0/wx5BRx38jwBupSBL9HPDq+Op 4XueCGjMApYHbc+xiDtJoqQ9UauFW2OCaMQQGSjhWNbdSGh6A4tqk4HR+ycvlZpZSvkY4VN929aDZ lsooxXG98r2sDAlaF2LQAar50cl7CsEAieCTcLjrUlq7BEeM+cJDRDyJM75MDOFUa3QA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1if7dX-0006xS-2G; Wed, 11 Dec 2019 20:27:03 +0100 Date: Wed, 11 Dec 2019 20:27:03 +0100 From: Andrew Lunn To: Landen Chao Cc: "f.fainelli@gmail.com" , "vivien.didelot@savoirfairelinux.com" , "matthias.bgg@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "davem@davemloft.net" , Sean Wang , "opensource@vdorst.com" , "frank-w@public-files.de" Subject: Re: [PATCH net-next 4/6] net: dsa: mt7530: Add the support of MT7531 switch Message-ID: <20191211192703.GC30053@lunn.ch> References: <6d608dd024edc90b09ba4fe35417b693847f973c.1575914275.git.landen.chao@mediatek.com> <20191210164438.GD27714@lunn.ch> <1576088280.23763.73.camel@mtksdccf07> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1576088280.23763.73.camel@mtksdccf07> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > Do you also hint at using the same number of parameters for > mt7531_ind_c22_phy_read() and mt7531_ind_c45_phy_read()? That is up to you. It just seems like your MDIO bus can do both C22 and C45. And somebody might connect an external C45 PHY, so you might as well support it. Andrew