From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3478EC43603 for ; Thu, 12 Dec 2019 12:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07C7F2077B for ; Thu, 12 Dec 2019 12:59:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gOQm/8nE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729092AbfLLM7O (ORCPT ); Thu, 12 Dec 2019 07:59:14 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59622 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729064AbfLLM7O (ORCPT ); Thu, 12 Dec 2019 07:59:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zur5xyiSqo2xJ830yHt30nv2fsD+zD/jl1PNVNPO19U=; b=gOQm/8nEdZRE6nXCBxHkEobBu 5uhOst9BFjVlAVcljEgbyf7/YeoAP4g+yl7FFyvBrsqrhqDPcF1oC5+lHhQYEU6bOi7EcePXriI67 3Hw+0azaByfFIMHP7DHeq1dD2HsqeBd2DGLAfy3/g8H0ZWCSJfp/FLBf+wwwCPXxzievt7rISXxhi UM4CEHtw4ocCUB0wfVlJCGoMGVDn0u1kvCDgp0ejr8hvCEGHy5V/kV7+0j3lzMWkKblPO5U7OYqPp mXMs5B6WQuFeaXcprcOzOFNy1Mjd2/Wlu5I2ozgeofPNe5Hm5W5/nO9Bd2QWnsvsLphCU+yHUXgVT QUxB2ibqw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifO3k-0004Q1-7a; Thu, 12 Dec 2019 12:59:12 +0000 Date: Thu, 12 Dec 2019 04:59:12 -0800 From: Christoph Hellwig To: Haren Myneni Cc: mpe@ellerman.id.au, devicetree@vger.kernel.org, mikey@neuling.org, herbert@gondor.apana.org.au, npiggin@gmail.com, hch@infradead.org, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH V2 05/13] powerpc/vas: Setup thread IRQ handler per VAS instance Message-ID: <20191212125912.GD3381@infradead.org> References: <1575861522.16318.9.camel@hbabu-laptop> <1575862284.16318.22.camel@hbabu-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575862284.16318.22.camel@hbabu-laptop> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Dec 08, 2019 at 07:31:24PM -0800, Haren Myneni wrote: > > Setup thread IRQ handler per each VAS instance. When NX sees a fault > on CRB, kernel gets an interrupt and vas_fault_handler will be > executed to process fault CRBs. Read all valid CRBs from fault FIFO, > determine the corresponding send window from CRB and process fault > requests. > > Signed-off-by: Sukadev Bhattiprolu > Signed-off-by: Haren Myneni > --- > arch/powerpc/platforms/powernv/vas-fault.c | 83 +++++++++++++++++++++++++++++ > arch/powerpc/platforms/powernv/vas-window.c | 60 +++++++++++++++++++++ > arch/powerpc/platforms/powernv/vas.c | 15 +++++- > arch/powerpc/platforms/powernv/vas.h | 4 ++ > 4 files changed, 161 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/vas-fault.c b/arch/powerpc/platforms/powernv/vas-fault.c > index b0258ed..e1e34c6 100644 > --- a/arch/powerpc/platforms/powernv/vas-fault.c > +++ b/arch/powerpc/platforms/powernv/vas-fault.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > > #include "vas.h" > @@ -25,6 +26,88 @@ > #define VAS_FAULT_WIN_FIFO_SIZE (4 << 20) > > /* > + * Process CRBs that we receive on the fault window. > + */ > +irqreturn_t vas_fault_handler(int irq, void *data) > +{ > + struct vas_instance *vinst = (struct vas_instance *)data; No need for the cast. > + crb = (struct coprocessor_request_block *)fifo; Or this one. > + if (vinst->fault_crbs == vinst->fault_fifo_size/CRB_SIZE) Missing whitespace before and after the / > + rc = request_threaded_irq(vinst->virq, NULL, vas_fault_handler, > + IRQF_ONESHOT, devname, vinst); > + if (rc) { > + pr_err("VAS[%d]: Request IRQ(%d) failed with %d\n", > + vinst->vas_id, vinst->virq, rc); > + } else { > + rc = vas_setup_fault_window(vinst); > + if (rc) > + free_irq(vinst->virq, vinst); > + } > > return rc; This would be a tad cleaner with proper goto unwinding: rc = request_threaded_irq(vinst->virq, NULL, vas_fault_handler, IRQF_ONESHOT, devname, vinst); if (rc) { pr_err("VAS[%d]: Request IRQ(%d) failed with %d\n", vinst->vas_id, vinst->virq, rc); goto out; } rc = vas_setup_fault_window(vinst); if (rc) goto out_free_irq; return 0; out_free_irq: free_irq(vinst->virq, vinst); out: return rc;