From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7405CC43603 for ; Thu, 12 Dec 2019 13:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54D3A227BF for ; Thu, 12 Dec 2019 13:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729316AbfLLNAb (ORCPT ); Thu, 12 Dec 2019 08:00:31 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:45762 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729191AbfLLNAa (ORCPT ); Thu, 12 Dec 2019 08:00:30 -0500 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1ifO4v-0003mN-3e; Thu, 12 Dec 2019 14:00:25 +0100 Date: Thu, 12 Dec 2019 14:00:25 +0100 From: Sebastian Andrzej Siewior To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Ellerman , Segher Boessenkool , Frank Rowand Subject: Re: [PATCH] of: Rework and simplify phandle cache to use a fixed size Message-ID: <20191212130025.elwei6m5lnjzjsau@linutronix.de> References: <20191211232345.24810-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191211232345.24810-1-robh@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2019-12-11 17:23:45 [-0600], Rob Herring wrote: > Change the implementation to a fixed size and use hash_32() as the > cache index. This greatly simplifies the implementation. It avoids The negative diffstat is nice. It solves the original issue I had and it did not introduce anything new, just tested it. So feel free to: Acked-by: Sebastian Andrzej Siewior Sebastian