From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633A9C43603 for ; Fri, 13 Dec 2019 21:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1238E2253D for ; Fri, 13 Dec 2019 21:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JuOGdNKU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726004AbfLMVl5 (ORCPT ); Fri, 13 Dec 2019 16:41:57 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:59072 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfLMVl5 (ORCPT ); Fri, 13 Dec 2019 16:41:57 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C548A9D6; Fri, 13 Dec 2019 22:41:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1576273316; bh=t5bAuI7IPLlm5mpJ9LwRwRzISVV2tE9EKaG7gmQn18Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JuOGdNKUkqakSrplVGU8RiV4mAjbKWhN1ZHLip3jTHCcSt7+2GN2Q3CiY95S71itP n4V35RY0bawu6dyICQUOm77xjaOMHEF2I/2yhMYNo9v8OCXdKvbQ+Jqx9TdCKyM799 HdfhShv2YMrR2WQLYxQhmBzO9YwdVoaSpqfvPfTM= Date: Fri, 13 Dec 2019 23:41:46 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Geert Uytterhoeven , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Thierry Reding , Maarten Lankhorst , Maxime Ripard , Sean Paul , Andrzej Hajda , Sam Ravnborg , Simon Horman , Magnus Damm , Kieran Bingham , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Jacopo Mondi , ebiharaml@si-linux.co.jp Subject: Re: [PATCH v4 5/7] drm: rcar-du: lvds: Fix mode for companion encoder Message-ID: <20191213214146.GP4860@pendragon.ideasonboard.com> References: <1575649974-31472-1-git-send-email-fabrizio.castro@bp.renesas.com> <1575649974-31472-6-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1575649974-31472-6-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Fri, Dec 06, 2019 at 04:32:52PM +0000, Fabrizio Castro wrote: > Primary and companion encoders need to set the same mode for > things to work properly. > > rcar_lvds_mode_set gets called into for the primary encoder only, > therefore initialize the companion encoder mode while sorting > the primary encoder mode out. > > Fixes: fa440d870358 ("drm: rcar-du: lvds: Add support for dual-link mode") > Signed-off-by: Fabrizio Castro Would you mind rebasing this on top of "drm: rcar-du: lvds: Get mode from state" ? > --- > v3->v4: > * New patch extracted from patch: > "drm: rcar-du: lvds: Add dual-LVDS panels support" > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index cb2147c..eed5611 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -614,6 +614,18 @@ static void rcar_lvds_mode_set(struct drm_bridge *bridge, > lvds->display_mode = *adjusted_mode; > > rcar_lvds_get_lvds_mode(lvds); > + if (lvds->companion) { > + struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds( > + lvds->companion); > + > + /* > + * FIXME: We should not be messing with the companion encoder > + * private data from the primary encoder, but since > + * rcar_lvds_mode_set gets called into for the primary encoder > + * only, we don't have much of a choice for now. > + */ > + companion_lvds->mode = lvds->mode; > + } > } > > static int rcar_lvds_attach(struct drm_bridge *bridge) -- Regards, Laurent Pinchart