From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
<linux-i2c@vger.kernel.org>
Cc: <tfiga@chromium.org>, <drinkcat@chromium.org>,
<srv_heupstream@mediatek.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
Bibby Hsieh <bibby.hsieh@mediatek.com>
Subject: [PATCH v9 4/4] i2c: core: support bus regulator controlling in adapter
Date: Mon, 16 Dec 2019 16:04:45 +0800 [thread overview]
Message-ID: <20191216080445.8747-5-bibby.hsieh@mediatek.com> (raw)
In-Reply-To: <20191216080445.8747-1-bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We get and enable bulk regulator in i2c adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/i2c/i2c-core-base.c | 65 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 3 ++
2 files changed, 68 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 9333c865d4a9..e95ebd0af200 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -306,6 +306,7 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap = client->adapter;
struct i2c_driver *driver;
int status;
@@ -371,6 +372,12 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ status = regulator_enable(adap->bus_reg);
+ if (status != 0) {
+ dev_err(&adap->dev, "Failed to enable power regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -407,6 +414,7 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap = client->adapter;
struct i2c_driver *driver;
int status = 0;
@@ -420,6 +428,8 @@ static int i2c_device_remove(struct device *dev)
}
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&adap->dev))
+ regulator_disable(adap->bus_reg);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -431,6 +441,54 @@ static int i2c_device_remove(struct device *dev)
return status;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap = client->adapter;
+
+ return pm_generic_resume(&adap->dev);
+}
+
+static int i2c_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap = client->adapter;
+
+ return pm_generic_suspend(&adap->dev);
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap = client->adapter;
+
+ pm_generic_runtime_resume(&adap->dev);
+
+ return regulator_enable(adap->bus_reg);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap = client->adapter;
+
+ pm_generic_runtime_suspend(&adap->dev);
+
+ if (!pm_runtime_status_suspended(&adap->dev))
+ return regulator_disable(client->adapter->bus_reg);
+
+ return 0;
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_SYSTEM_SLEEP_PM_OPS(i2c_suspend, i2c_resume)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -488,6 +546,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
@@ -1351,6 +1410,11 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
goto out_reg;
dev_dbg(&adap->dev, "adapter [%s] registered\n", adap->name);
+ adap->bus_reg = devm_regulator_get(&adap->dev, "bus");
+ if (IS_ERR(adap->bus_reg)) {
+ res = PTR_ERR(adap->bus_reg);
+ goto out_reg;
+ }
pm_runtime_no_callbacks(&adap->dev);
pm_suspend_ignore_children(&adap->dev, true);
@@ -1580,6 +1644,7 @@ void i2c_del_adapter(struct i2c_adapter *adap)
dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name);
pm_runtime_disable(&adap->dev);
+ devm_regulator_put(adap->bus_reg);
i2c_host_notify_irq_teardown(adap);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index d2f786706657..833b81a680da 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -330,6 +331,7 @@ struct i2c_client {
int init_irq; /* irq set at initialization */
int irq; /* irq issued by device */
struct list_head detected;
+
#if IS_ENABLED(CONFIG_I2C_SLAVE)
i2c_slave_cb_t slave_cb; /* callback for slave mode */
#endif
@@ -723,6 +725,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_reg;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.18.0
next prev parent reply other threads:[~2019-12-16 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 8:04 [PATCH v9 0/4] add power control in i2c and at24 Bibby Hsieh
2019-12-16 8:04 ` [PATCH v9 1/4] dt-binding: eeprom: at24: add vcc-supply property Bibby Hsieh
2019-12-16 8:04 ` [PATCH v9 2/4] dt-binding: i2c: add bus-supply property Bibby Hsieh
2019-12-18 14:47 ` Rob Herring
2019-12-16 8:04 ` [PATCH v9 3/4] misc: eeprom: at24: support pm_runtime control Bibby Hsieh
2019-12-19 10:50 ` Bartosz Golaszewski
2020-01-06 7:09 ` Bibby Hsieh
2019-12-16 8:04 ` Bibby Hsieh [this message]
2019-12-16 11:58 ` [PATCH v9 4/4] i2c: core: support bus regulator controlling in adapter Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216080445.8747-5-bibby.hsieh@mediatek.com \
--to=bibby.hsieh@mediatek.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).