From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E2DC2D0C3 for ; Mon, 16 Dec 2019 14:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B14F206EC for ; Mon, 16 Dec 2019 14:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576508134; bh=G5qmjCDdT1w/WFe2hlox5kS/aHkrbDR0OUGRD1SamhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ht+1M5ydagd1rJDon4uDxnBBV8K32bFDPHWIFFu2q69ynRn3HgkI9C3h8KcKGjick +AjrJCZlsP0xH5lrRrR0bINH1mpuoX5fqbNpcegMK9vFje0wt62a9/9xsYzCiygCk6 ubwgBr9cSmVjiQuGW7UddiZ2M0B8OZYnK79wtThQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbfLPOzd (ORCPT ); Mon, 16 Dec 2019 09:55:33 -0500 Received: from foss.arm.com ([217.140.110.172]:57962 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbfLPOzd (ORCPT ); Mon, 16 Dec 2019 09:55:33 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6664A1FB; Mon, 16 Dec 2019 06:55:32 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D91B93F718; Mon, 16 Dec 2019 06:55:31 -0800 (PST) Date: Mon, 16 Dec 2019 14:55:28 +0000 From: Mark Brown To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Mark Rutland , Lee Jones , Liam Girdwood , Jonathan Corbet , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Arnd Bergmann , Mauro Carvalho Chehab , Wolfram Sang , Phil Edworthy , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Message-ID: <20191216145528.GE4161@sirena.org.uk> References: <5b1c4a22c7945e97ff2a7924abfeb3239043f8eb.1576054779.git.matti.vaittinen@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vv4Sf/kQfcwinyKX" Content-Disposition: inline In-Reply-To: <5b1c4a22c7945e97ff2a7924abfeb3239043f8eb.1576054779.git.matti.vaittinen@fi.rohmeurope.com> X-Cookie: Backed up the system lately? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --vv4Sf/kQfcwinyKX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 11, 2019 at 11:46:11AM +0200, Matti Vaittinen wrote: > +static int bd71828_ldo6_get_voltage(struct regulator_dev *rdev) > +{ > + return BD71828_LDO_6_VOLTAGE; > +} > + > +static const struct regulator_ops bd71828_ldo6_ops = { > + .enable = regulator_enable_regmap, > + .disable = regulator_disable_regmap, > + .get_voltage = bd71828_ldo6_get_voltage, You can just set fixed_uV in the regulator_desc, you don't need a get_voltage() operation here. Otherwise this looks good, I'll apply it and please send an incremental fix for this. --vv4Sf/kQfcwinyKX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl33mt8ACgkQJNaLcl1U h9DPqggAhcsF1ZeRBaP6Lzz9ZA0lX48wnM91c45AzpXxhBPVmVU8EJrJFkmUT+zI VYHCWzrWqZoUwoxRDUntTg0W7omOi4CoU10/2SGjxkdxHiAmutKvaV8e155DaKRj hhZGeaSRdWgD3uYUZGBB1W9OYmzuHx6NtlL76FfabMt6TTPQCq7X3VjSuI4wi4oN 7JLtu6Gzf2WNSmP1uqZLMSqk1RvgZa2K1rgRwf+SYhTD21VWliTuq/qGtg0zmijW BA398k1yTl123ecTnS9Fnk+IsqPSTd/mBJT4TmFkdakxVm3JSYIqpqIiJYZtGOBs aUVTHrBVlYfYIk4raTP8w2l2xYiNdg== =0wbA -----END PGP SIGNATURE----- --vv4Sf/kQfcwinyKX--