From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C872C43603 for ; Tue, 17 Dec 2019 06:40:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1CD421739 for ; Tue, 17 Dec 2019 06:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbfLQGkN (ORCPT ); Tue, 17 Dec 2019 01:40:13 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:48571 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfLQGkN (ORCPT ); Tue, 17 Dec 2019 01:40:13 -0500 Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ih6Wg-0006mX-3m; Tue, 17 Dec 2019 07:40:10 +0100 Received: from mfe by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ih6Wf-0001MH-Gn; Tue, 17 Dec 2019 07:40:09 +0100 Date: Tue, 17 Dec 2019 07:40:09 +0100 From: Marco Felsch To: Linus Walleij Cc: Adam Thomson , Support Opensource , "lee.jones@linaro.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [RESEND PATCH v3 3/3] pinctrl: da9062: add driver support Message-ID: <20191217064009.GB31182@pengutronix.de> References: <20191212160413.15232-1-m.felsch@pengutronix.de> <20191212160413.15232-4-m.felsch@pengutronix.de> <20191216074734.ctjxx6rqtj6mt2dw@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:38:49 up 109 days, 18:52, 74 users, load average: 0.32, 0.49, 0.49 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::28 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19-12-16 11:33, Linus Walleij wrote: > On Mon, Dec 16, 2019 at 8:47 AM Marco Felsch wrote: > > > Nice catch, Linus is it okay to add this as follow up patch? The current > > patch isn't wrong without the 'PIN_CONFIG_BIAS_DISABLE' case. > > No strong opinion on that as long as the result is running code. Of course the code is running and was tested. Just didn't covered this use case. Adam is this okay with you? Regards, Marco > Yours, > Linus Walleij >