From: Vincent Cheng <vincent.cheng.xh@renesas.com>
To: David Miller <davem@davemloft.net>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] ptp: clockmatrix: Remove IDT references or replace with Renesas.
Date: Wed, 18 Dec 2019 14:45:09 +0000 [thread overview]
Message-ID: <20191218144446.GA25453@renesas.com> (raw)
In-Reply-To: <20191217.222956.2055609890870202125.davem@davemloft.net>
On Wed, Dec 18, 2019 at 01:29:56AM EST, David Miller wrote:
>From: vincent.cheng.xh@renesas.com
>Date: Tue, 17 Dec 2019 00:03:07 -0500
>
>> From: Vincent Cheng <vincent.cheng.xh@renesas.com>
>>
>> Renesas Electronics Corporation completed acquisition of IDT in 2019.
>>
>> This patch removes IDT references or replaces IDT with Renesas.
>> Renamed idt8a340_reg.h to clockmatrix_reg.h.
>> There were no functional changes.
>>
>> Signed-off-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
>
>Sorry, we don't do stuff like this.
>
>The driver shall keep the reference to it's old vendor name, and
>this is how we've handled similar situations in the past.
Sorry, was not aware.
>And do you know the worst part about this? You DID in fact
>functionally change this driver:
>
>> -#define FW_FILENAME "idtcm.bin"
>> +#define FW_FILENAME "cm_tcs.bin"
>
>Now everyone would have missing firmware.
>
>So not only is this unacceptable on precedence grounds, and how we
>always handle situations like this, it's functionally wrong and would
>break things for users.
>
>Please remove this patch and resubmit #1 and #3 as a series for
>re-review.
What is the proper way to remove a patch submission?
Regards,
Vincent
next prev parent reply other threads:[~2019-12-18 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 5:03 [PATCH net-next 0/3] Replace IDT with Renesas and improve version info vincent.cheng.xh
2019-12-17 5:03 ` [PATCH net-next 1/3] dt-bindings: ptp: Rename ptp-idtcm.yaml to ptp-cm.yaml vincent.cheng.xh
2019-12-26 19:22 ` Rob Herring
2019-12-28 17:25 ` Vincent Cheng
2019-12-17 5:03 ` [PATCH net-next 2/3] ptp: clockmatrix: Remove IDT references or replace with Renesas vincent.cheng.xh
2019-12-18 6:29 ` David Miller
2019-12-18 14:45 ` Vincent Cheng [this message]
2019-12-18 20:23 ` David Miller
2019-12-17 5:03 ` [PATCH net-next 3/3] ptp: clockmatrix: Rework clockmatrix version information vincent.cheng.xh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218144446.GA25453@renesas.com \
--to=vincent.cheng.xh@renesas.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).