* [PATCH v3 0/7] Clock changes to support cpufreq on QCS404
@ 2019-11-25 13:59 Niklas Cassel
2019-11-25 13:59 ` [PATCH v3 1/7] dt-bindings: mailbox: qcom: Add clock-name optional property Niklas Cassel
2019-12-18 12:16 ` [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
0 siblings, 2 replies; 4+ messages in thread
From: Niklas Cassel @ 2019-11-25 13:59 UTC (permalink / raw)
To: linux-arm-msm
Cc: amit.kucheria, sboyd, bjorn.andersson, Niklas Cassel, devicetree,
linux-kernel, linux-clk
The following clock changes are required to enable cpufreq support on
the QCS404.
Changes since v2:
-Addressed Stephen Boyd's comment regarding apcs-msm8916
should use new way of specifying clock parents.
-DT binding now has "pll" as first clock, in order to
not break DT backwards compatibility (in case no clock-names
are given).
-Moved EPROBE_DEFER error handling to its own patch.
Jorge Ramirez-Ortiz (6):
dt-bindings: mailbox: qcom: Add clock-name optional property
clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency
clk: qcom: hfpll: register as clock provider
clk: qcom: hfpll: CLK_IGNORE_UNUSED
clk: qcom: hfpll: use clk_parent_data to specify the parent
clk: qcom: apcs-msm8916: silently error out on EPROBE_DEFER
Niklas Cassel (1):
clk: qcom: apcs-msm8916: use clk_parent_data to specify the parent
.../mailbox/qcom,apcs-kpss-global.txt | 24 ++++++++++++++---
drivers/clk/qcom/apcs-msm8916.c | 26 ++++++++++++++-----
drivers/clk/qcom/clk-alpha-pll.c | 8 ++++++
drivers/clk/qcom/clk-alpha-pll.h | 1 +
drivers/clk/qcom/gcc-qcs404.c | 2 +-
drivers/clk/qcom/hfpll.c | 21 +++++++++++++--
6 files changed, 70 insertions(+), 12 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/7] dt-bindings: mailbox: qcom: Add clock-name optional property
2019-11-25 13:59 [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
@ 2019-11-25 13:59 ` Niklas Cassel
2019-12-19 6:24 ` Stephen Boyd
2019-12-18 12:16 ` [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
1 sibling, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2019-11-25 13:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: linux-arm-msm, amit.kucheria, sboyd, Jorge Ramirez-Ortiz,
Niklas Cassel, Rob Herring, Mark Rutland, devicetree,
linux-kernel
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
When the APCS clock is registered (platform dependent), it retrieves
its parent names from hardcoded values in the driver.
The following commit allows the DT node to provide such clock names to
the platform data based clock driver therefore avoiding having to
explicitly embed those names in the clock driver source code.
Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes since v2:
-Swapped order of "pll" and "aux", in order to not break
DT backwards compatibility (in case no clock-names are given).
.../mailbox/qcom,apcs-kpss-global.txt | 24 ++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
index 0278482af65c..beec612dbe6a 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
@@ -21,10 +21,11 @@ platforms.
Usage: required
Value type: <prop-encoded-array>
Definition: must specify the base address and size of the global block
+
- clocks:
- Usage: required if #clocks-cells property is present
- Value type: <phandle>
- Definition: phandle to the input PLL, which feeds the APCS mux/divider
+ Usage: required if #clock-names property is present
+ Value type: <phandle array>
+ Definition: phandles to the two parent clocks of the clock driver.
- #mbox-cells:
Usage: required
@@ -36,6 +37,12 @@ platforms.
Value type: <u32>
Definition: as described in clock.txt, must be 0
+- clock-names:
+ Usage: required if the platform data based clock driver needs to
+ retrieve the parent clock names from device tree.
+ This will requires two mandatory clocks to be defined.
+ Value type: <string-array>
+ Definition: must be "pll" and "aux"
= EXAMPLE
The following example describes the APCS HMSS found in MSM8996 and part of the
@@ -68,3 +75,14 @@ Below is another example of the APCS binding on MSM8916 platforms:
clocks = <&a53pll>;
#clock-cells = <0>;
};
+
+Below is another example of the APCS binding on QCS404 platforms:
+
+ apcs_glb: mailbox@b011000 {
+ compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+ reg = <0x0b011000 0x1000>;
+ #mbox-cells = <1>;
+ clocks = <&apcs_hfpll>, <&gcc GCC_GPLL0_AO_OUT_MAIN>;
+ clock-names = "pll", "aux";
+ #clock-cells = <0>;
+ };
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 0/7] Clock changes to support cpufreq on QCS404
2019-11-25 13:59 [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
2019-11-25 13:59 ` [PATCH v3 1/7] dt-bindings: mailbox: qcom: Add clock-name optional property Niklas Cassel
@ 2019-12-18 12:16 ` Niklas Cassel
1 sibling, 0 replies; 4+ messages in thread
From: Niklas Cassel @ 2019-12-18 12:16 UTC (permalink / raw)
To: sboyd
Cc: linux-arm-msm, amit.kucheria, sboyd, bjorn.andersson, devicetree,
linux-kernel, linux-clk, niklas.cassel
On Mon, Nov 25, 2019 at 02:59:02PM +0100, Niklas Cassel wrote:
> The following clock changes are required to enable cpufreq support on
> the QCS404.
>
> Changes since v2:
> -Addressed Stephen Boyd's comment regarding apcs-msm8916
> should use new way of specifying clock parents.
> -DT binding now has "pll" as first clock, in order to
> not break DT backwards compatibility (in case no clock-names
> are given).
> -Moved EPROBE_DEFER error handling to its own patch.
>
> Jorge Ramirez-Ortiz (6):
> dt-bindings: mailbox: qcom: Add clock-name optional property
> clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency
> clk: qcom: hfpll: register as clock provider
> clk: qcom: hfpll: CLK_IGNORE_UNUSED
> clk: qcom: hfpll: use clk_parent_data to specify the parent
> clk: qcom: apcs-msm8916: silently error out on EPROBE_DEFER
>
> Niklas Cassel (1):
> clk: qcom: apcs-msm8916: use clk_parent_data to specify the parent
>
> .../mailbox/qcom,apcs-kpss-global.txt | 24 ++++++++++++++---
> drivers/clk/qcom/apcs-msm8916.c | 26 ++++++++++++++-----
> drivers/clk/qcom/clk-alpha-pll.c | 8 ++++++
> drivers/clk/qcom/clk-alpha-pll.h | 1 +
> drivers/clk/qcom/gcc-qcs404.c | 2 +-
> drivers/clk/qcom/hfpll.c | 21 +++++++++++++--
> 6 files changed, 70 insertions(+), 12 deletions(-)
>
> --
> 2.23.0
>
Hello Stephen,
I have adressed your review comments
on the previous patch series version.
Could you please have a look?
If it looks good, could you please
consider taking them via your tree?
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/7] dt-bindings: mailbox: qcom: Add clock-name optional property
2019-11-25 13:59 ` [PATCH v3 1/7] dt-bindings: mailbox: qcom: Add clock-name optional property Niklas Cassel
@ 2019-12-19 6:24 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-12-19 6:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Niklas Cassel
Cc: linux-arm-msm, amit.kucheria, Jorge Ramirez-Ortiz, Niklas Cassel,
Rob Herring, Mark Rutland, devicetree, linux-kernel
Quoting Niklas Cassel (2019-11-25 05:59:03)
> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>
> When the APCS clock is registered (platform dependent), it retrieves
> its parent names from hardcoded values in the driver.
>
> The following commit allows the DT node to provide such clock names to
> the platform data based clock driver therefore avoiding having to
> explicitly embed those names in the clock driver source code.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-19 6:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 13:59 [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
2019-11-25 13:59 ` [PATCH v3 1/7] dt-bindings: mailbox: qcom: Add clock-name optional property Niklas Cassel
2019-12-19 6:24 ` Stephen Boyd
2019-12-18 12:16 ` [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).