From: Greg KH <gregkh@linuxfoundation.org>
To: shubhrajyoti.datta@gmail.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, arnd@arndb.de, robh+dt@kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCH v2 2/3] misc: xilinx_flex: Add support for the flex noc Performance Monitor
Date: Thu, 19 Dec 2019 18:21:39 +0100 [thread overview]
Message-ID: <20191219172139.GB2092676@kroah.com> (raw)
In-Reply-To: <469d8bdde24055e01141b79a936dbd64c2481cc2.1575609926.git.shubhrajyoti.datta@xilinx.com>
On Fri, Dec 06, 2019 at 11:09:57AM +0530, shubhrajyoti.datta@gmail.com wrote:
> +/**
> + * xflex_remove - Driver remove function
> + * @pdev: Pointer to the platform_device structure
> + *
> + * This function frees all the resources allocated to the device.
> + *
> + * Return: 0 always
> + */
No need for kerneldoc documentation for static functions.
> +static int xflex_remove(struct platform_device *pdev)
> +{
> + sysfs_remove_groups(&pdev->dev.kobj, xflex_groups);
Your attribute groups can, and should, be automatically created by the
driver core. Set the driver's dev_groups pointer and that will happen
for you.
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-19 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 5:39 [PATCH v2 1/3] dt-bindings: Add dt bindings for flex noc Performance Monitor shubhrajyoti.datta
2019-12-06 5:39 ` [PATCH v2 2/3] misc: xilinx_flex: Add support for the " shubhrajyoti.datta
2019-12-19 17:21 ` Greg KH [this message]
2019-12-06 5:39 ` [PATCH v2 3/3] Documentation: short descriptions for Flexnoc Performance Monitor driver shubhrajyoti.datta
2019-12-18 22:27 ` [PATCH v2 1/3] dt-bindings: Add dt bindings for flex noc Performance Monitor Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219172139.GB2092676@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).