From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: madalin.bucur@nxp.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com, shawnguo@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] net: phy: add interface modes for XFI, SFI
Date: Thu, 19 Dec 2019 17:28:34 +0000 [thread overview]
Message-ID: <20191219172834.GC25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <1576768881-24971-2-git-send-email-madalin.bucur@oss.nxp.com>
On Thu, Dec 19, 2019 at 05:21:16PM +0200, Madalin Bucur wrote:
> From: Madalin Bucur <madalin.bucur@nxp.com>
>
> Add explicit entries for XFI, SFI to make sure the device
> tree entries for phy-connection-type "xfi" or "sfi" are
> properly parsed and differentiated against the existing
> backplane 10GBASE-KR mode.
10GBASE-KR is actually used for XFI and SFI (due to a slight mistake on
my part, it should've been just 10GBASE-R).
Please explain exactly what the difference is between XFI, SFI and
10GBASE-R. I have not been able to find definitive definitions for
XFI and SFI anywhere, and they appear to be precisely identical to
10GBASE-R. It seems that it's just a terminology thing, with
different groups wanting to "own" what is essentially exactly the
same interface type.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> ---
> include/linux/phy.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 5032d453ac66..ebb793621f0b 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -99,7 +99,8 @@ typedef enum {
> PHY_INTERFACE_MODE_2500BASEX,
> PHY_INTERFACE_MODE_RXAUI,
> PHY_INTERFACE_MODE_XAUI,
> - /* 10GBASE-KR, XFI, SFI - single lane 10G Serdes */
> + PHY_INTERFACE_MODE_XFI,
> + PHY_INTERFACE_MODE_SFI,
> PHY_INTERFACE_MODE_10GKR,
> PHY_INTERFACE_MODE_USXGMII,
> PHY_INTERFACE_MODE_MAX,
> @@ -175,6 +176,10 @@ static inline const char *phy_modes(phy_interface_t interface)
> return "rxaui";
> case PHY_INTERFACE_MODE_XAUI:
> return "xaui";
> + case PHY_INTERFACE_MODE_XFI:
> + return "xfi";
> + case PHY_INTERFACE_MODE_SFI:
> + return "sfi";
> case PHY_INTERFACE_MODE_10GKR:
> return "10gbase-kr";
> case PHY_INTERFACE_MODE_USXGMII:
> --
> 2.1.0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-12-19 17:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:21 [PATCH 0/6] Add PHY connection types for XFI and SFI Madalin Bucur
2019-12-19 15:21 ` [PATCH 1/6] net: phy: add interface modes for XFI, SFI Madalin Bucur
2019-12-19 17:28 ` Russell King - ARM Linux admin [this message]
2019-12-19 18:32 ` Madalin Bucur
2019-12-19 19:03 ` Russell King - ARM Linux admin
2019-12-19 21:34 ` Madalin Bucur (OSS)
2019-12-19 21:49 ` Russell King - ARM Linux admin
2019-12-20 7:38 ` Madalin Bucur (OSS)
2019-12-20 9:16 ` Russell King - ARM Linux admin
2019-12-20 9:29 ` Andrew Lunn
2019-12-20 9:39 ` Madalin Bucur (OSS)
2019-12-20 10:06 ` Andrew Lunn
2019-12-23 7:50 ` Madalin Bucur (OSS)
2019-12-23 8:26 ` Russell King - ARM Linux admin
2019-12-23 9:57 ` Madalin Bucur (OSS)
2019-12-23 10:57 ` Russell King - ARM Linux admin
2019-12-23 12:07 ` Russell King - ARM Linux admin
2019-12-23 13:46 ` Andrew Lunn
2019-12-23 14:30 ` Russell King - ARM Linux admin
2020-01-03 7:01 ` Madalin Bucur (OSS)
2020-01-03 9:27 ` Russell King - ARM Linux admin
2020-01-03 9:42 ` Russell King - ARM Linux admin
2020-01-03 12:03 ` Madalin Bucur (OSS)
2020-01-03 12:53 ` Russell King - ARM Linux admin
2020-01-03 13:35 ` Andrew Lunn
2020-01-03 16:21 ` Madalin Bucur (OSS)
2020-01-03 17:17 ` Andrew Lunn
2020-01-06 9:34 ` Madalin Bucur (OSS)
2020-01-03 15:57 ` Madalin Bucur (OSS)
2020-01-03 17:19 ` Russell King - ARM Linux admin
2020-01-06 10:17 ` Madalin Bucur (OSS)
2020-01-06 13:57 ` Andrew Lunn
2020-01-06 15:03 ` Madalin Bucur (OSS)
2019-12-19 15:21 ` [PATCH 2/6] arm64: dts: ls104xardb: set correct PHY interface mode Madalin Bucur
2019-12-19 16:05 ` Andrew Lunn
2019-12-19 18:09 ` Madalin Bucur (OSS)
2019-12-19 15:21 ` [PATCH 3/6] net: fsl/fman: rename IF_MODE_XGMII to IF_MODE_10G Madalin Bucur
2019-12-19 15:21 ` [PATCH 4/6] net: fsl/fman: add support for PHY_INTERFACE_MODE_XFI Madalin Bucur
2019-12-19 15:21 ` [PATCH 5/6] net: fsl/fman: add support for PHY_INTERFACE_MODE_SFI Madalin Bucur
2019-12-19 17:30 ` Russell King - ARM Linux admin
2019-12-19 18:50 ` Madalin Bucur (OSS)
2019-12-19 15:21 ` [PATCH 6/6] net: phy: aquantia: add support for PHY_INTERFACE_MODE_XFI Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219172834.GC25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).