From: Rob Herring <robh@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: kishon@ti.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, tomi.valkeinen@ti.com,
praneeth@ti.com, yamonkar@cadence.com, sjakhade@cadence.com,
rogerq@ti.com
Subject: Re: [PATCH 2/3] dt-bindings: phy: Add lane<n>-mode property to WIZ (SERDES wrapper)
Date: Thu, 19 Dec 2019 13:08:33 -0600 [thread overview]
Message-ID: <20191219190833.GA16358@bogus> (raw)
In-Reply-To: <fb79923b1591cc5f26b6973beb92ce503ad3f4d1.1575906694.git.jsarha@ti.com>
On Mon, Dec 09, 2019 at 06:22:11PM +0200, Jyri Sarha wrote:
> Add property to indicate the usage of SERDES lane controlled by the
> WIZ wrapper. The wrapper configuration has some variation depending on
> how each lane is going to be used.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
> .../devicetree/bindings/phy/ti,phy-j721e-wiz.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
> index 94e3b4b5ed8e..399725f65278 100644
> --- a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
> @@ -97,6 +97,18 @@ patternProperties:
> Torrent SERDES should follow the bindings specified in
> Documentation/devicetree/bindings/phy/phy-cadence-dp.txt
>
> + "^lane[1-4]-mode$":
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - enum: [0, 1, 2, 3, 4, 5, 6]
> + description: |
> + Integer describing static lane usage for the lane indicated in
> + the property name. For Sierra there may be properties lane0 and
> + lane1, for Torrent all lane[1-4]-mode properties may be
> + there. The constants to indicate the lane usage are defined in
> + "include/dt-bindings/phy/phy.h". The lane is assumed to be unused
> + if its lane<n>-use property does not exist.
The defines were intended to be in 'phys' cells. Does putting both lane
and mode in the client 'phys' properties not work?
Rob
next prev parent reply other threads:[~2019-12-19 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 16:20 [PATCH 0/3] phy: ti: j721e-wiz: Add support for DisplayPort mode Jyri Sarha
2019-12-09 16:21 ` [PATCH 1/3] dt-bindings: phy: Add PHY_TYPE_DP definition Jyri Sarha
2019-12-19 19:04 ` Rob Herring
2019-12-09 16:22 ` [PATCH 2/3] dt-bindings: phy: Add lane<n>-mode property to WIZ (SERDES wrapper) Jyri Sarha
2019-12-19 19:08 ` Rob Herring [this message]
2019-12-20 12:52 ` Jyri Sarha
2019-12-24 21:31 ` Rob Herring
2019-12-30 9:37 ` Jyri Sarha
2019-12-30 10:18 ` Kishon Vijay Abraham I
2019-12-30 11:54 ` Jyri Sarha
2019-12-30 18:21 ` Rob Herring
2019-12-09 16:22 ` [PATCH 3/3] phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219190833.GA16358@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=praneeth@ti.com \
--cc=rogerq@ti.com \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ti.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).