From: Kamel Bouhara <kamel.bouhara@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding
Date: Fri, 20 Dec 2019 11:09:44 +0100 [thread overview]
Message-ID: <20191220100944.GB2601@kb-xps> (raw)
In-Reply-To: <20191218202345.GA22591@bogus>
On Wed, Dec 18, 2019 at 02:23:45PM -0600, Rob Herring wrote:
> On Mon, Dec 09, 2019 at 10:13:38AM +0100, Kamel Bouhara wrote:
> > Document devicetree's bindings for the Overkiz's Kizbox Mini and
> > Smartkiz boards, based on a SAM9G25 Atmel SoC.
> >
> > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> > ---
> > Changes in v2
> > =============
> > - Added Kizboxmini Base board documentation
> > - Merged Smartkiz documentation as it is also a sam9g25 based
> > board
> >
> > Changes in v3
> > =============
> > - Made a single items list with all the sam9g25 based boards and
> > put description into a comment.
> > - Fixed duplicated item in enum list and checked with 'make
> > dt_binding_check'
> >
> > Changes in v4
> > =============
> > - Fix missing "-" before items list
> >
> > Changes in v5
> > =============
> > - s/at91-kizboxmini_common.dtsi/at91-kizboxmini-common.dtsi/
> > ---
> > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > index 6dd8be401673..8d50915330e8 100644
> > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > @@ -35,6 +35,16 @@ properties:
> > - atmel,at91sam9x60
> > - const: atmel,at91sam9
> >
> > + - items:
> > + - enum:
> > + - overkiz,kizboxmini-base # Overkiz kizbox Mini Base Board
> > + - overkiz,kizboxmini-mb # Overkiz kizbox Mini Mother Board
> > + - overkiz,kizboxmini-rd # Overkiz kizbox Mini RailDIN
> > + - overkiz,smartkiz # Overkiz SmartKiz Board
>
> Should be indented 2 fewer spaces. Otherwise,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Ok, thanks.
Cheers,
>
> > + - const: atmel,at91sam9g25
> > + - const: atmel,at91sam9x5
> > + - const: atmel,at91sam9
> > +
> > - items:
> > - enum:
> > - atmel,at91sam9g15
> > --
> > 2.24.0
> >
--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-12-20 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 9:13 [PATCH v5 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding Kamel Bouhara
2019-12-09 9:13 ` [PATCH v5 2/2] ARM: dts: at91: add smartkiz support and a common kizboxmini dtsi file Kamel Bouhara
2019-12-18 20:23 ` [PATCH v5 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding Rob Herring
2019-12-20 10:09 ` Kamel Bouhara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220100944.GB2601@kb-xps \
--to=kamel.bouhara@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).