From: Rob Herring <robh@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Andy Gross <agross@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH] dt-bindings: timer: Use non-empty ranges in example
Date: Thu, 26 Dec 2019 14:07:10 -0700 [thread overview]
Message-ID: <20191226210710.GA19454@bogus> (raw)
In-Reply-To: <CAD=FV=Wb6MtqdBZgNWdTH97RZamYfPZ0a9_1CELE_kJHXtKuYQ@mail.gmail.com>
On Mon, Dec 16, 2019 at 10:16:56PM -0800, Doug Anderson wrote:
> Hi,
>
> On Mon, Dec 16, 2019 at 10:06 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > On many arm64 qcom device trees, running `make dtbs_check` yells:
> >
> > timer@17c20000: #size-cells:0:0: 1 was expected
> >
> > It appears that someone was trying to assert the fact that sub-nodes
> > describing frames would never have a size that's more than 32-bits
> > big. That does indeed appear to be true for all cases I could find.
> >
> > Currently many arm64 qcom device tree files have a #address-cells and
> > about in commit bede7d2dc8f3 ("arm64: dts: qcom: sdm845: Increase
> > address and size cells for soc"). That means the only way we can
> > shrink them down is to use a non-empty ranges.
> >
> > Since forever it has said in "writing-bindings.txt" to "DO use
> > non-empty 'ranges' to limit the size of child buses/devices". I guess
> > we should start listening to it.
I probably need to condition that to account for dma-ranges as you
wouldn't want to limit the bus in that case.
> >
> > I believe (but am not certain) that this also means that we should use
> > "ranges" to simplify the "reg" of our sub devices by specifying an
> > offset. Let's update the example in the bindings to make this
> > obvious.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> > See:
> > https://lore.kernel.org/r/20191212113540.7.Ia9bd3fca24ad34a5faaf1c3e58095c74b38abca1@changeid
> >
> > ...for the patch that sparked this change.
> >
> > .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> > index b3f0fe96ff0d..d927b42ddeb8 100644
> > --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> > +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> > @@ -99,22 +99,22 @@ examples:
> > compatible = "arm,armv7-timer-mem";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > - ranges;
> > + ranges = <0 0xf0000000 0x1000>;
>
> I checked this over a few times and yet I still screwed it up. :(
> This should be:
>
> ranges = <0 0xf0001000 0x1000>;
>
> ...which makes the first "frame" below actually start at 0. I'll wait
> before sending out a v2, though, in case this patch is totally wrong
> or something.
Looks good to me.
Rob
prev parent reply other threads:[~2019-12-26 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:05 [PATCH] dt-bindings: timer: Use non-empty ranges in example Douglas Anderson
2019-12-17 6:16 ` Doug Anderson
2019-12-26 21:07 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226210710.GA19454@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).