From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sricharan R <sricharan@codeaurora.org>
Cc: agross@kernel.org, devicetree@vger.kernel.org,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-soc@vger.kernel.org, robh+dt@kernel.org, sboyd@kernel.org,
sivaprak@codeaurora.org
Subject: Re: [PATCH V2 2/7] pinctrl: qcom: Add ipq6018 pinctrl driver
Date: Sat, 28 Dec 2019 19:35:30 -0800 [thread overview]
Message-ID: <20191229033530.GN3755841@builder> (raw)
In-Reply-To: <1576752109-24497-3-git-send-email-sricharan@codeaurora.org>
On Thu 19 Dec 02:41 PST 2019, Sricharan R wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq6018.c b/drivers/pinctrl/qcom/pinctrl-ipq6018.c
[..]
> +static const struct msm_function ipq6018_functions[] = {
[..]
> + FUNCTION(qpic_pad),
> + FUNCTION(qpic_pad0),
> + FUNCTION(qpic_pad1),
> + FUNCTION(qpic_pad2),
> + FUNCTION(qpic_pad3),
> + FUNCTION(qpic_pad4),
> + FUNCTION(qpic_pad5),
> + FUNCTION(qpic_pad6),
> + FUNCTION(qpic_pad7),
> + FUNCTION(qpic_pad8),
Shouldn't the qpic_padN entries be removed now? (Please double check the
rest as well)
[..]
> +
> +static const struct msm_pingroup ipq6018_groups[] = {
> + PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, _, burn0, _, _, _, _),
> + PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, _, burn1, _, _, _, _),
> + PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(5, qpic_pad, mac21, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(6, qpic_pad, mac21, qdss_tracedata_b, _, _, _, _, _, _),
> + PINGROUP(7, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(8, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(9, qpic_pad, atest_char, cxc0, mac13, dbg_out, qdss_tracedata_b, _, _, _),
> + PINGROUP(10, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(11, qpic_pad, wci22, mac12, qdss_tracedata_b, _, _, _, _, _),
> + PINGROUP(12, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(13, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(14, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(15, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _),
> + PINGROUP(16, qpic_pad, cxc0, mac13, qdss_tracedata_b, _, _, _, _, _),
> + PINGROUP(17, qpic_pad, qdss_tracedata_b, wci22, _, _, _, _, _, _),
Regards,
Bjorn
next prev parent reply other threads:[~2019-12-29 3:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:41 [PATCH V2 0/7] Add minimal boot support for IPQ6018 Sricharan R
2019-12-19 10:41 ` [PATCH V2 1/7] dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl bindings Sricharan R
2019-12-29 3:41 ` Bjorn Andersson
2019-12-30 9:12 ` Sricharan R
2019-12-19 10:41 ` [PATCH V2 2/7] pinctrl: qcom: Add ipq6018 pinctrl driver Sricharan R
2019-12-29 3:35 ` Bjorn Andersson [this message]
2019-12-30 9:10 ` Sricharan R
2019-12-19 10:41 ` [PATCH V2 3/7] dt-bindings: qcom: Add ipq6018 bindings Sricharan R
2019-12-19 10:41 ` [PATCH V2 4/7] clk: qcom: Add DT bindings for ipq6018 gcc clock controller Sricharan R
2019-12-19 18:24 ` Rob Herring
2019-12-19 10:41 ` [PATCH V2 5/7] clk: qcom: Add ipq6018 Global Clock Controller support Sricharan R
2019-12-27 1:33 ` Stephen Boyd
2019-12-30 9:06 ` Sricharan R
2019-12-19 10:41 ` [PATCH V2 6/7] arm64: dts: Add ipq6018 SoC and CP01 board support Sricharan R
2019-12-29 3:29 ` Bjorn Andersson
2019-12-30 9:10 ` Sricharan R
2019-12-19 10:41 ` [PATCH V2 7/7] arm64: defconfig: Enable qcom ipq6018 clock and pinctrl Sricharan R
2019-12-27 1:33 ` [PATCH V2 0/7] Add minimal boot support for IPQ6018 Stephen Boyd
2019-12-30 9:07 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191229033530.GN3755841@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sivaprak@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).