From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51801C2D0C3 for ; Mon, 30 Dec 2019 20:00:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19D912071E for ; Mon, 30 Dec 2019 20:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577736025; bh=LXaYelecrLVC5uffYCP8s5MxYuo5nX3oqttyGrW6o44=; h=In-Reply-To:References:From:Cc:To:Subject:Date:List-ID:From; b=pidnoOp3vRbaxqL9HwzSlPd1YHVc7qGx6HZPHPUvmGvApqFszVodigWBRcVx1GFwU kc6gDeYoT6kxxp5w4/c4ZrZOY87Q8VubhGTZhJm79QWITNyWULM2emaypXp7zvZZBL aBTOsb2bPkd+ZauNHUOt3aiwL+8ptS6g1KBsE8NU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbfL3UAY (ORCPT ); Mon, 30 Dec 2019 15:00:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:42934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727680AbfL3UAY (ORCPT ); Mon, 30 Dec 2019 15:00:24 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EE1020718; Mon, 30 Dec 2019 20:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577736023; bh=LXaYelecrLVC5uffYCP8s5MxYuo5nX3oqttyGrW6o44=; h=In-Reply-To:References:From:Cc:To:Subject:Date:From; b=v2E8zYIZ0676IxwIxJmutkFGwfO4VUvmig7VUdocIMGXP2swnm151mODkxZPFqkTS i4M/wMk4E2PIJl9lUdsG2q2jcEjs54CMqPnEXgfbPviIVW5d44dc6QBlP3u04disMt pHP6E7JKQa3YJWvOExrIbS4S+IGXepJgO0ov51PM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20191210172108.38868-2-tony@atomide.com> References: <20191210172108.38868-1-tony@atomide.com> <20191210172108.38868-2-tony@atomide.com> From: Stephen Boyd Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, Rob Herring To: Michael Turquette , Stephen Boyd , Tero Kristo , Tony Lindgren Subject: Re: [PATCH 1/5] clk: ti: clkctrl: Fix hidden dependency to node name User-Agent: alot/0.8.1 Date: Mon, 30 Dec 2019 12:00:22 -0800 Message-Id: <20191230200023.9EE1020718@mail.kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Tony Lindgren (2019-12-10 09:21:04) > We currently have a hidden dependency to the device tree node name for > the clkctrl clocks. Instead of using standard node name like "clock", we > must use "l4-per-clkctrl" type naming so the clock driver can find the > associated clock domain. Further, if "clk" is specified for a clock node > name, the driver sets TI_CLK_CLKCTRL_COMPAT flag that uses different > logic for the clock name based on the parent node name for the all the > clkctrl clocks for the SoC. >=20 > If the clock node naming dependency is not understood, the related > clockdomain is not found, or a wrong one can get used if a clock manager > has multiple clock domains. >=20 > As each clkctrl instance represents a single clock domain, let's allow > using domain specific compatible names to specify the clock domain. >=20 > This simplifies things and removes the hidden dependency to the node > name. And then later on, after the node names have been standardized, > we can drop the related code for parsing the node names. >=20 > Let's also update the binding to use standard "clock" node naming > instead of "clk" and add the missing description for reg. >=20 > Cc: devicetree@vger.kernel.org > Cc: Rob Herring > Signed-off-by: Tony Lindgren > --- Acked-by: Stephen Boyd