From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9D5C2D0C3 for ; Mon, 30 Dec 2019 21:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C604020658 for ; Mon, 30 Dec 2019 21:03:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="nYqdilDu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbfL3VDE (ORCPT ); Mon, 30 Dec 2019 16:03:04 -0500 Received: from rere.qmqm.pl ([91.227.64.183]:11540 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727691AbfL3VDD (ORCPT ); Mon, 30 Dec 2019 16:03:03 -0500 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 47mqdd0DMQz7N; Mon, 30 Dec 2019 22:03:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1577739781; bh=NNyRepO9YhRpotCRnJnXy8pqk04Hj9WYZM8yTYKVSKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYqdilDubgYoiO7q7ir4AhKr8ggJoA91XK6Sjk9p095YyYgl0RiFO1mK50hybP3yU i6uDIqspV/CnmzP4Rs/3vCMbxydoTkFl4LJ55mWd+DSNfhB/05u3tRA7emehjh+MTm wt8yx4Jrs0z8lekEuiNi2htVGxTd5cEMaIk2CKu7un8f2xxcNce5IiwvHiiLtrjRvU LvGOZ/espqLCs4SVyMwZSTCqH3vDqU5ksVGBGuuBQiPYLvzVSh1HIwZU3bJvleqpM1 dFATpChED97WwmAWe74O/eAQJRARWfa4vfqr1v3mquGkuZkmJKqRZRjCrWvSdmmHZI MOJ+GImum0JYg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.4 at mail Date: Mon, 30 Dec 2019 22:02:59 +0100 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Dmitry Osipenko Cc: Peter Chen , Rob Herring , Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Felipe Balbi , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 10/10] usb: chipidea: tegra: Add USB_TEGRA_PHY module to driver's dependencies Message-ID: <20191230210259.GD24135@qmqm.qmqm.pl> References: <20191220015238.9228-1-digetx@gmail.com> <20191220015238.9228-11-digetx@gmail.com> <20191220035650.GC19921@b29397-desktop> <20191223213234.GA28786@qmqm.qmqm.pl> <7174833f-8325-7fb4-d190-78ba4bed0cbb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7174833f-8325-7fb4-d190-78ba4bed0cbb@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Dec 24, 2019 at 07:21:05AM +0300, Dmitry Osipenko wrote: > 24.12.2019 00:32, Michał Mirosław пишет: > > On Fri, Dec 20, 2019 at 07:31:08AM +0300, Dmitry Osipenko wrote: > >> 20.12.2019 06:56, Peter Chen пишет: > >>> On 19-12-20 04:52:38, Dmitry Osipenko wrote: > > [...] > >>>> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > >>>> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > >>>> @@ -53,6 +53,12 @@ static int tegra_udc_probe(struct platform_device *pdev) > >>>> struct tegra_udc *udc; > >>>> int err; > >>>> > >>>> + if (IS_MODULE(CONFIG_USB_TEGRA_PHY)) { > >>>> + err = request_module("phy_tegra_usb"); > >>>> + if (err) > >>>> + return err; > >>>> + } > >>>> + > >>> > >>> Why you do this dependency, if this controller driver can't > >>> get USB PHY, it should return error. What's the return value > >>> after calling below: > >>> > >>> udc->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "nvidia,phy", 0); > >> > >> It returns -EPROBE_DEFER when phy_tegra_usb isn't loaded. > > > > How are other driver modules autoloaded? Isn't there an appropriate > > MODALIAS or MODULE_DEVICE_TABLE in there? > > Hello Michał, > > The phy_tegra_usb module is fine by itself, it's getting autoloaded. > > The problem is that ci_hdrc_tegra module depends on the phy_tegra_usb > module and thus the PHY module should be loaded before the CI module, > otherwise CI driver fails with the EPROBE_DEFER. Why, then, is CI driver not being probed again after PHY driver loads? EPROBE_DEFER is what should cause driver core to re-probe a device after other devices appear (PHY in this case). Best Regards, Michał Mirosław