From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA35DC2D0C2 for ; Fri, 3 Jan 2020 17:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA22220866 for ; Fri, 3 Jan 2020 17:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="CROChRXS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbgACRRZ (ORCPT ); Fri, 3 Jan 2020 12:17:25 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46722 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727952AbgACRRZ (ORCPT ); Fri, 3 Jan 2020 12:17:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6DWrB1umXlgJmXfg/wK6IDqVDNHFHyv/eiqcp2/lHpg=; b=CROChRXS3rMrORIX6bjd5yfAep b5cz1zo4a2An628AzQ9qFS3uxXAVRedSDfGonVwm2E4oVnVV5V7iY+H8pB6kOp6qKZ/fTGMhJu/+z +9KnFhCrhNLLVc+pKHgaG9VuB+PaiZ6fI43OsKCkvySJelZ3kaK9z1i/nap662VrEJ44=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1inQZb-0000Yu-Ri; Fri, 03 Jan 2020 18:17:19 +0100 Date: Fri, 3 Jan 2020 18:17:19 +0100 From: Andrew Lunn To: "Madalin Bucur (OSS)" Cc: Russell King - ARM Linux admin , "devicetree@vger.kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "shawnguo@kernel.org" Subject: Re: [PATCH 1/6] net: phy: add interface modes for XFI, SFI Message-ID: <20200103171719.GM1397@lunn.ch> References: <20191219172834.GC25745@shell.armlinux.org.uk> <20191223120730.GO25745@shell.armlinux.org.uk> <20200103092718.GB25745@shell.armlinux.org.uk> <20200103094204.GA18808@shell.armlinux.org.uk> <20200103125310.GE25745@shell.armlinux.org.uk> <20200103133523.GA22988@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > There are many things pushed down to u-boot so the Linux driver has less > work to do, that's one of the reasons there is little left there. I prefer barebox. Which is a problem, since it sounds like Ethernet will be broken on your boards if i swap to it. If you are going to offload setting up the hardware, please do it to firmware. That is independent of the bootloader. The Marvell SoCs do this for their low level SERDES setup, making SMC calls into the firmware. https://patchwork.kernel.org/cover/10880297/ > Ideally this dependency should be removed but then we'd need to make > a clearer distinction. As you've noticed, currently I don't even > need to distinguish XFI from SFI because for basic scenarios the > code does the same thing. Problem is, if I select a common > denominator now, and later I need to make this distinction, I'll > need to update device trees, code, etc. Just like "xgmii" was just > fine as a placeholder until recently. I'd rather use a correct > description now. So it seems like you need two properties. You need a property to tell your bootloader how to configure the electrical properties of the SERDES, XFI, SFI, etc. And you need a property to configure the protocol running over the SERDES, which is phy-mode. Andrew