From: Rob Herring <robh@kernel.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Vikash Garodia <vgarodia@codeaurora.org>,
dikshita@codeaurora.org
Subject: Re: [PATCH v3 06/12] dt-bindings: media: venus: Convert msm8916 to DT schema
Date: Fri, 3 Jan 2020 16:59:02 -0700 [thread overview]
Message-ID: <20200103235902.GA7619@bogus> (raw)
In-Reply-To: <20191223113311.20602-7-stanimir.varbanov@linaro.org>
On Mon, Dec 23, 2019 at 01:33:05PM +0200, Stanimir Varbanov wrote:
> Convert qcom,msm8916-venus Venus binding to DT schema
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> .../bindings/media/qcom,msm8916-venus.yaml | 117 ++++++++++++++++++
> 1 file changed, 117 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> new file mode 100644
> index 000000000000..14331c16135c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Venus video encode and decode accelerators
> +
> +maintainers:
> + - Stanimir Varbanov <stanimir.varbanov@linaro.org>
> +
> +description: |
> + The Venus IP is a video encode and decode accelerator present
> + on Qualcomm platforms
> +
> +properties:
> + compatible:
> + const: "qcom,msm8916-venus"
No need for quotes.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 3
> +
> + clock-names:
> + items:
> + - const: core
> + - const: iface
> + - const: bus
> +
> + iommus:
> + minItems: 1
> + maxItems: 20
You can have 20 IOMMUs attached to the Venus IP? The binding is for 1
SoC, you should know how many IOMMUs there are.
> +
> + memory-region:
> + maxItems: 1
> +
> + video-decoder:
> + type: object
> +
> + properties:
> + compatible:
> + const: "venus-decoder"
> +
> + required:
> + - compatible
> +
> + additionalProperties: false
> +
> + video-encoder:
> + type: object
> +
> + properties:
> + compatible:
> + const: "venus-encoder"
> +
> + required:
> + - compatible
> +
> + additionalProperties: false
> +
> + video-firmware:
> + type: object
> +
> + description: |
> + Firmware subnode is needed when the platform does not
> + have TrustZone.
> +
> + properties:
> + iommus:
> + minItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - power-domains
> + - clocks
> + - clock-names
> + - iommus
> + - memory-region
> + - video-decoder
> + - video-encoder
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/qcom,gcc-msm8916.h>
> +
> + video-codec@1d00000 {
> + compatible = "qcom,msm8916-venus";
> + reg = <0x01d00000 0xff000>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>,
> + <&gcc GCC_VENUS0_AHB_CLK>,
> + <&gcc GCC_VENUS0_AXI_CLK>;
> + clock-names = "core", "iface", "bus";
> + power-domains = <&gcc VENUS_GDSC>;
> + iommus = <&apps_iommu 5>;
> + memory-region = <&venus_mem>;
> +
> + video-decoder {
> + compatible = "venus-decoder";
> + };
> +
> + video-encoder {
> + compatible = "venus-encoder";
> + };
> + };
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-01-03 23:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 11:32 [PATCH v3 00/12] Venus new features Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 01/12] venus: redesign clocks and pm domains control Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 02/12] media: venus: introduce core selection Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 03/12] venus: venc: blacklist two encoder properties Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 04/12] v4l: Add source event change for bit-depth Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 05/12] media: venus: vdec: handle 10bit bitstreams Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 06/12] dt-bindings: media: venus: Convert msm8916 to DT schema Stanimir Varbanov
2020-01-03 23:59 ` Rob Herring [this message]
2019-12-23 11:33 ` [PATCH v3 07/12] dt-bindings: media: venus: Convert msm8996 " Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 08/12] dt-bindings: media: venus: Convert sdm845 " Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 09/12] dt-bindings: media: venus: Add sdm845v2 " Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 10/12] venus: core: add sdm845-v2 DT compatible and resource struct Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 11/12] arm64: dts: sdm845: follow venus-sdm845v2 DT binding Stanimir Varbanov
2019-12-23 11:33 ` [PATCH v3 12/12] dt-bindings: media: venus: delete old binding document Stanimir Varbanov
2020-01-04 0:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103235902.GA7619@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).