From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8F1C00523 for ; Mon, 6 Jan 2020 00:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B2B22072C for ; Mon, 6 Jan 2020 00:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgAFAiR (ORCPT ); Sun, 5 Jan 2020 19:38:17 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:56062 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgAFAiQ (ORCPT ); Sun, 5 Jan 2020 19:38:16 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id F259F8050A; Mon, 6 Jan 2020 01:38:10 +0100 (CET) Date: Mon, 6 Jan 2020 01:38:09 +0100 From: Sam Ravnborg To: Paul Cercueil Cc: Thierry Reding , Rob Herring , Mark Rutland , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Message-ID: <20200106003809.GA552@ravnborg.org> References: <20191202154123.64139-1-paul@crapouillou.net> <20191202154123.64139-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202154123.64139-3-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=4eiu5t_5MPiKWv0nutYA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Paul. On Mon, Dec 02, 2019 at 04:41:23PM +0100, Paul Cercueil wrote: > The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for > instance inside the Anbernic RG-350 handheld gaming console. > > v2: Order alphabetically > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 28fa6ba7b767..0e5e33a57f0c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1402,6 +1402,32 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = { > .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > }; > > +static const struct drm_display_mode frida_frd350h54004_mode = { > + .clock = 6777, > + .hdisplay = 320, > + .hsync_start = 320 + 70, > + .hsync_end = 320 + 70 + 50, > + .htotal = 320 + 70 + 50 + 10, > + .vdisplay = 240, > + .vsync_start = 240 + 5, > + .vsync_end = 240 + 5 + 1, > + .vtotal = 240 + 5 + 1 + 5, > + .vrefresh = 60, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > +}; > + > +static const struct panel_desc frida_frd350h54004 = { > + .modes = &frida_frd350h54004_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 77, > + .height = 64, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE, > +}; connector_type is mandatory for new panel-simple panels. Sam > + > static const struct drm_display_mode friendlyarm_hd702e_mode = { > .clock = 67185, > .hdisplay = 800, > @@ -3189,6 +3215,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "foxlink,fl500wvr00-a0t", > .data = &foxlink_fl500wvr00_a0t, > + }, { > + .compatible = "frida,frd350h54004", > + .data = &frida_frd350h54004, > }, { > .compatible = "friendlyarm,hd702e", > .data = &friendlyarm_hd702e, > -- > 2.24.0