From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
dri-devel@lists.freedesktop.org,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chris Healy <cphealy@gmail.com>,
devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
Rob Herring <robh+dt@kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH v5 1/4] drm/bridge: Add a drm_bridge_state object
Date: Mon, 6 Jan 2020 13:52:07 +0200 [thread overview]
Message-ID: <20200106115207.GB4853@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200106110354.0a5cbc10@collabora.com>
On Mon, Jan 06, 2020 at 11:03:54AM +0100, Boris Brezillon wrote:
> On Thu, 19 Dec 2019 11:11:48 +0100 Neil Armstrong wrote:
>
> > +/**
> > + * drm_atomic_helper_duplicate_bridge_state() - Default duplicate state helper
> > + * @bridge: bridge containing the state to duplicate
> > + *
> > + * Default implementation of &drm_bridge_funcs.atomic_duplicate().
> > + *
> > + * RETURNS:
> > + * a valid state object or NULL if the allocation fails.
> > + */
> > +struct drm_bridge_state *
> > +drm_atomic_helper_bridge_duplicate_state(struct drm_bridge *bridge)
> > +{
> > + struct drm_bridge_state *new;
> > +
> > + if (WARN_ON(!bridge->base.state))
> > + return NULL;
> > +
> > + new = kzalloc(sizeof(*new), GFP_KERNEL);
> > + if (new)
> > + __drm_atomic_helper_bridge_duplicate_state(bridge, new);
> > +
> > + return new;
> > +}
> > +EXPORT_SYMBOL(drm_atomic_helper_bridge_duplicate_state);
>
> IIRC, Laurent suggested to make those functions private. I'd also
> recommend changing the names to
> drm_atomic_*default*_bridge_<action>_state() and dropping the kernel doc
> header since making them static means they're no longer helper
> functions.
Please note that static functions may still benefit from documentation.
In this specific case the documentation can probably be dropped, but if
other functions have useful comments, please keep them.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-01-06 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:11 [PATCH v5 0/4] drm: Add support for bus-format negotiation Neil Armstrong
2019-12-19 10:11 ` [PATCH v5 1/4] drm/bridge: Add a drm_bridge_state object Neil Armstrong
2019-12-19 21:52 ` Jernej Škrabec
2020-01-06 10:03 ` Boris Brezillon
2020-01-06 10:41 ` Neil Armstrong
2020-01-06 11:52 ` Laurent Pinchart [this message]
2019-12-19 10:11 ` [PATCH v5 2/4] drm/bridge: Patch atomic hooks to take a drm_bridge_state Neil Armstrong
2019-12-19 21:53 ` Jernej Škrabec
2019-12-19 10:11 ` [PATCH v5 3/4] drm/bridge: Add an ->atomic_check() hook Neil Armstrong
2019-12-19 21:53 ` Jernej Škrabec
2019-12-19 10:11 ` [PATCH v5 4/4] drm/bridge: Add the necessary bits to support bus format negotiation Neil Armstrong
2019-12-19 21:56 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106115207.GB4853@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=andrew.smirnov@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).