From: Viresh Kumar <viresh.kumar@linaro.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Georgi Djakov <georgi.djakov@linaro.org>,
vincent.guittot@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, adharmap@codeaurora.org,
Rajendra Nayak <rnayak@codeaurora.org>,
sibis@codeaurora.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, kernel-team@android.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 0/3] Introduce Bandwidth OPPs for interconnects
Date: Wed, 8 Jan 2020 16:55:55 +0530 [thread overview]
Message-ID: <20200108112522.afg535ybfxrlypcv@vireshk-i7> (raw)
In-Reply-To: <20191207002424.201796-1-saravanak@google.com>
On 06-12-19, 16:24, Saravana Kannan wrote:
> Viresh/Stephen,
>
> I don't think all the additional code/diff in this v6 series is worth it
> to avoid using the rate field to store peak bandwidth. However, since folks
> weren't too happy about it, here it is. I prefer the v5 series, but not
> too strongly tied to it. Let me know what you think Viresh/Stephen.
>
> Btw, I wasn't sure of opp-hz = 0
I am not sure either ;)
> or opp-level = 0 were allowed. Also,
I think this is allowed.
> it's not clear why the duplicate check isn't done for opp-level when
> _opp_add() is called. Based on that, we could add opp-level comparison
This should be done. Please do that in the first patch as I suggested
in the code as well.
> to opp_compare_key(). That's why you'll see a few spurious
> opp_key.level = 0 lines. Let me know how you want to go with that.
>
> I could also add a opp.key_type enum field to store what key type the
> opp entry is. But looks like I can get away without adding an
> unnecessary variable. So, I've skipped that for now.
Not in the OPP struct, but such an enum can be used for helper
routines as I commented.
--
viresh
next prev parent reply other threads:[~2020-01-08 11:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 0:24 [PATCH v6 0/3] Introduce Bandwidth OPPs for interconnects Saravana Kannan
2019-12-07 0:24 ` [PATCH v6 1/3] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings Saravana Kannan
2020-01-08 10:32 ` Viresh Kumar
2020-01-09 0:32 ` Saravana Kannan
2019-12-07 0:24 ` [PATCH v6 2/3] OPP: Add support for bandwidth OPP tables Saravana Kannan
2020-01-07 19:28 ` Sibi Sankar
2020-01-08 6:16 ` Saravana Kannan
2020-01-29 13:40 ` Sibi Sankar
2020-01-08 10:53 ` Viresh Kumar
2020-01-09 0:58 ` Saravana Kannan
2020-01-09 4:31 ` Viresh Kumar
2020-01-09 18:35 ` Saravana Kannan
2020-01-10 6:54 ` Viresh Kumar
2019-12-07 0:24 ` [PATCH v6 3/3] OPP: Add helper function " Saravana Kannan
2020-01-08 11:19 ` Viresh Kumar
2020-01-09 0:58 ` Saravana Kannan
2020-01-09 3:36 ` Saravana Kannan
2020-01-09 4:41 ` Viresh Kumar
2020-01-09 4:40 ` Viresh Kumar
2020-01-09 18:44 ` Saravana Kannan
2020-01-10 7:01 ` Viresh Kumar
2020-01-08 11:25 ` Viresh Kumar [this message]
2020-01-14 10:34 ` [PATCH v6 0/3] Introduce Bandwidth OPPs for interconnects Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108112522.afg535ybfxrlypcv@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=adharmap@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).