From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECFEC33CAE for ; Mon, 13 Jan 2020 21:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC81F2072B for ; Mon, 13 Jan 2020 21:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578950457; bh=cNuwSX6Tq6Xza4J+uNzGgshgLrwQpNsZgM0BcS4sN7Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CivcwzgWJ3oS4VHu/EXurSOaoWI0O5xfTShuRvDFvgX9c0tHkGfUYHQeFYuP+Ocxl 4RC+RybpvqWQbFerAit/WT/FOnT89u62sgIsWAry8Y6WweV2UC9whUN8IppZKsqueU +tJE6dCdatWxdMJzj9w5qClvcJYLed8ExCjWZYWE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727137AbgAMVUy (ORCPT ); Mon, 13 Jan 2020 16:20:54 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:42345 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbgAMVUy (ORCPT ); Mon, 13 Jan 2020 16:20:54 -0500 Received: by mail-oi1-f195.google.com with SMTP id 18so9733366oin.9 for ; Mon, 13 Jan 2020 13:20:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UkcwH+aLJlMDz8EGk6FkQZlCk8V9rUaFgodvX0X0qKI=; b=PBGCPdtIo70PcrsE7nNXiNrNofCPaTPkuTLO7sgcxFQw1X2XX+Box0zXUbEe6NZojh xdhfq4igdltKocWf1cuAssLOuQiFYJ8bA/gFlkUMUQPC017Mku1yefA+Ekja4yVVt2K/ t32qIFC3/N7SHg5YSusE8bL2BncrFxPM0PxSaXSyhOabP4C/WIXAEFIKYSVXDNioF7Hy KHeRJhDJlvFdL89e6oI+VRLrIWrx4mDBHkzOZ+qu3hzNOLfHIYiSJH7H5+7zcO9E9TE1 kcO8c3f1QKR6PsXewiWnnG5NJBx0BDflSWDGozVkgLetrAxWNr46FFK3yenn3b48WyDA AfCg== X-Gm-Message-State: APjAAAULhgMVh5uWhA8xUA2vLAcbVgIHzkvbPQzgNz1ePj5i6NciM3cq FwWCOz48F5uJ35AAlYfwSCoXu3A= X-Google-Smtp-Source: APXvYqzrcaR3Ms98Ae09bhMxyU6sgmYM+/+gbq6qDXn5nR3qjpAsqhl6dbV4mqxbTk783G8o6BFfCA== X-Received: by 2002:aca:b60a:: with SMTP id g10mr13688278oif.102.1578950452575; Mon, 13 Jan 2020 13:20:52 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i20sm4539717otl.74.2020.01.13.13.20.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 13:20:51 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 221998 by rob-hp-laptop (DragonFly Mail Agent v0.11); Mon, 13 Jan 2020 15:20:50 -0600 Date: Mon, 13 Jan 2020 15:20:50 -0600 From: Rob Herring To: Sandeep Maheswaram Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , Mark Rutland , Stephen Boyd , Doug Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Manu Gautam Subject: Re: [PATCH v3 2/5] dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings to yaml Message-ID: <20200113212050.GA21793@bogus> References: <1578658699-30458-1-git-send-email-sanm@codeaurora.org> <1578658699-30458-3-git-send-email-sanm@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578658699-30458-3-git-send-email-sanm@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jan 10, 2020 at 05:48:16PM +0530, Sandeep Maheswaram wrote: > Convert QUSB2 phy bindings to DT schema format using json-schema. > > Signed-off-by: Sandeep Maheswaram > --- > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 152 +++++++++++++++++++++ > .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 68 --------- > 2 files changed, 152 insertions(+), 68 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt Fails 'make dt_binding_check': builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.example.dt.yaml: phy@88e2000: 'vdda-phy-dpdm-supply' is a required property > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > new file mode 100644 > index 0000000..83cd01d > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > @@ -0,0 +1,152 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm QUSB2 phy controller > + > +maintainers: > + - Manu Gautam > + > +description: > + QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > + > +properties: > + compatible: > + anyOf: anyOf is usually wrong. Use 'oneOf'. > + - items: > + - const: qcom,msm8996-qusb2-phy > + - items: > + - const: qcom,msm8998-qusb2-phy > + - items: > + - const: qcom,sc7180-qusb2-phy > + - items: > + - const: qcom,sdm845-qusb2-phy These 4 can be a single enum. However, you should drop sc7180 and sdm845. Those should match below. (Or drop the below. Just pick which way and fixup any dts files that don't conform.) > + - items: > + - enum: > + - qcom,sc7180-qusb2-phy > + - qcom,sdm845-qusb2-phy > + - const: qcom,qusb2-v2-phy > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 0 > + > + clocks: > + minItems: 2 > + items: > + - description: phy config clock > + - description: 19.2 MHz ref clk > + - description: phy interface clock (Optional) > + > + clock-names: > + minItems: 2 > + items: > + - const: cfg_ahb > + - const: ref > + - const: iface > + > + vdda-pll-supply: > + description: > + Phandle to 1.8V regulator supply to PHY refclk pll block. > + > + vdda-phy-dpdm-supply: > + description: > + Phandle to 3.1V regulator supply to Dp/Dm port signals. > + > + resets: > + maxItems: 1 > + > + nvmem-cells: > + maxItems: 1 > + description: > + Phandle to nvmem cell that contains 'HS Tx trim' > + tuning parameter value for qusb2 phy. > + > + qcom,tcsr-syscon: > + description: > + Phandle to TCSR syscon register region. > + $ref: /schemas/types.yaml#/definitions/cell s/cell/phandle/ > + > + qcom,imp-res-offset-value: > + description: > + It is a 6 bit value that specifies offset to be > + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY > + tuning parameter that may vary for different boards of same SOC. > + This property is applicable to only QUSB2 v2 PHY. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 63 > + default: 0 > + > + qcom,hstx-trim-value: > + description: > + It is a 4 bit value that specifies tuning for HSTX > + output current. > + Possible range is - 15mA to 24mA (stepsize of 600 uA). > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > + This property is applicable to only QUSB2 v2 PHY. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 15 > + default: 3 > + > + qcom,preemphasis-level: > + description: > + It is a 2 bit value that specifies pre-emphasis level. > + Possible range is 0 to 15% (stepsize of 5%). > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > + This property is applicable to only QUSB2 v2 PHY. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 3 > + default: 2 > + > + qcom,preemphasis-width: > + description: > + It is a 1 bit value that specifies how long the HSTX > + pre-emphasis (specified using qcom,preemphasis-level) must be in > + effect. Duration could be half-bit of full-bit. > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > + This property is applicable to only QUSB2 v2 PHY. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 1 > + default: 0 > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + - clocks > + - clock-names > + - vdda-pll-supply > + - vdda-phy-dpdm-supply > + - resets > + > + > +examples: > + - | > + #include > + #include > + usb_1_hsphy: phy@88e2000 { > + compatible = "qcom,sdm845-qusb2-phy"; > + reg = <0 0x088e2000 0 0x400>; > + #phy-cells = <0>; > + > + clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, > + <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "cfg_ahb", "ref"; > + > + resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; > + > + nvmem-cells = <&qusb2p_hstx_trim>; > + }; > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > deleted file mode 100644 > index fe29f9e..0000000 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ /dev/null > @@ -1,68 +0,0 @@ > -Qualcomm QUSB2 phy controller > -============================= > - > -QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > - > -Required properties: > - - compatible: compatible list, contains > - "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > - "qcom,msm8998-qusb2-phy" for 10nm PHY on msm8998, > - "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. > - > - - reg: offset and length of the PHY register set. > - - #phy-cells: must be 0. > - > - - clocks: a list of phandles and clock-specifier pairs, > - one for each entry in clock-names. > - - clock-names: must be "cfg_ahb" for phy config clock, > - "ref" for 19.2 MHz ref clk, > - "iface" for phy interface clock (Optional). > - > - - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block. > - - vdda-phy-dpdm-supply: Phandle to 3.1V regulator supply to Dp/Dm port signals. > - > - - resets: Phandle to reset to phy block. > - > -Optional properties: > - - nvmem-cells: Phandle to nvmem cell that contains 'HS Tx trim' > - tuning parameter value for qusb2 phy. > - > - - qcom,tcsr-syscon: Phandle to TCSR syscon register region. > - - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be > - added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY > - tuning parameter that may vary for different boards of same SOC. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > - - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX > - output current. > - Possible range is - 15mA to 24mA (stepsize of 600 uA). > - See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > - Default value is 22.2mA for sdm845. > - - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. > - Possible range is 0 to 15% (stepsize of 5%). > - See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > - Default value is 10% for sdm845. > -- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX > - pre-emphasis (specified using qcom,preemphasis-level) must be in > - effect. Duration could be half-bit of full-bit. > - See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > - This property is applicable to only QUSB2 v2 PHY (sdm845). > - Default value is full-bit width for sdm845. > - > -Example: > - hsusb_phy: phy@7411000 { > - compatible = "qcom,msm8996-qusb2-phy"; > - reg = <0x7411000 0x180>; > - #phy-cells = <0>; > - > - clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, > - <&gcc GCC_RX1_USB2_CLKREF_CLK>, > - clock-names = "cfg_ahb", "ref"; > - > - vdda-pll-supply = <&pm8994_l12>; > - vdda-phy-dpdm-supply = <&pm8994_l24>; > - > - resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; > - nvmem-cells = <&qusb2p_hstx_trim>; > - }; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >