From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48CCC33CB2 for ; Tue, 14 Jan 2020 16:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B33802187F for ; Tue, 14 Jan 2020 16:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbgANQYS (ORCPT ); Tue, 14 Jan 2020 11:24:18 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:39727 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgANQYS (ORCPT ); Tue, 14 Jan 2020 11:24:18 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irOz2-0004VT-7w; Tue, 14 Jan 2020 17:24:00 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1irOz1-0004qL-Lg; Tue, 14 Jan 2020 17:23:59 +0100 Date: Tue, 14 Jan 2020 17:23:59 +0100 From: Marco Felsch To: Adam Thomson Cc: Support Opensource , "linux@roeck-us.net" , "robh+dt@kernel.org" , "lee.jones@linaro.org" , Steve Twiss , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [PATCH 1/3] mfd: da9062: fix watchdog compatible string Message-ID: <20200114162359.weoirknje6yhcmds@pengutronix.de> References: <20200108095704.23233-1-m.felsch@pengutronix.de> <20200108095704.23233-2-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:20:29 up 60 days, 7:39, 57 users, load average: 0.47, 0.25, 0.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20-01-14 16:19, Adam Thomson wrote: > On 08 January 2020 09:57, Marco Felsch wrote: > > > The watchdog driver compatible is "dlg,da9062-watchdog" and not > > "dlg,da9062-wdt". Therefore the mfd-core can't populate the of_node and > > fwnode. As result the watchdog driver can't parse the devicetree. > > > > I do agree there's a mismatch between the documentation and the MFD code. > So in your DT are you specifying 'dlg,da9062-watchdog' and not 'dlg,da9062-wdt' > hence the issue? Are there any existing users who are using 'dlg,da9062-wdt' in > their DT instead? Yes the upstream available DT I'm currently using is: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi. I grep the code and found no _upstream_ user of 'dlg,da9062-wdt' also using this compatible would be a missmatch with the binding documentation. So those DT's assuming a wrong binding. Therefore I fixed it here and not within the watchdog driver. Regards, Marco > > Fixes: 9b40b030c4ad ("mfd: da9062: Supply core driver") > > Signed-off-by: Marco Felsch > > --- > > drivers/mfd/da9062-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c > > index e69626867c26..9143de7b77b8 100644 > > --- a/drivers/mfd/da9062-core.c > > +++ b/drivers/mfd/da9062-core.c > > @@ -248,7 +248,7 @@ static const struct mfd_cell da9062_devs[] = { > > .name = "da9062-watchdog", > > .num_resources = ARRAY_SIZE(da9062_wdt_resources), > > .resources = da9062_wdt_resources, > > - .of_compatible = "dlg,da9062-wdt", > > + .of_compatible = "dlg,da9062-watchdog", > > }, > > { > > .name = "da9062-thermal", > > -- > > 2.20.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |