From: Marco Felsch <m.felsch@pengutronix.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: mchehab@kernel.org, hans.verkuil@cisco.com,
jacopo+renesas@jmondi.org, robh+dt@kernel.org,
laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
kernel@pengutronix.de, linux-media@vger.kernel.org
Subject: Re: [PATCH v11 04/15] media: v4l2-fwnode: add initial connector parsing support
Date: Wed, 15 Jan 2020 18:06:21 +0100 [thread overview]
Message-ID: <20200115170621.jszy2p3e4w3b3hpn@pengutronix.de> (raw)
In-Reply-To: <20191115233439.GB2696@mara.localdomain>
Hi Sakari,
On 19-11-16 01:34, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Sep 30, 2019 at 11:38:49AM +0200, Marco Felsch wrote:
...
Let me sum up our irc discussion about that kAPI.
Our starting point is a fwnode based subdev which has connectors in
front of there pins. Connectors are used to limit the subdev to some
device limits e.g. if the device support only PAL-Input streams and the
subdev has an buggy autodetect mechanism. In that case the connector can
be used by the subdev to set the possible TV-Norms to PAL. Currently the
tvp5150 is the only fwnode based subdev implementing connectors.
Connectors have common and connector specific properties. All current
provided connectors can be found here:
Documentation/devicetree/bindings/display/connector/ .
Parsing the properties is common to all _upcoming_ fwnode based subdevs
so this should be done within the core. So lets move on to the parsing
helper.
> > +int v4l2_fwnode_connector_alloc_parse(struct fwnode_handle *fwnode,
> > + struct v4l2_fwnode_connector *connector)
> > +{
This kAPI seems to fit all current use cases. The API is not responsible
to alloc the 'struct v4l2_fwnode_connector' instead it is only used to
fill this struct. The given 'struct fwnode_handle' should be the subdev
local ep-fwnode because the user already has a reference to this ep.
This helper has two use-cases:
1) Parsing the connector properties and add the initial (1st) link.
2) Add further n-links upon n-calls to an already parsed connector.
Going this way we need to ensure that the caller init the 'struct
v4l2_fwnode_connector' to '0' before call this helper. This can be
documented within the kAPI doc.
Regards,
Marco
next prev parent reply other threads:[~2020-01-15 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190930093900.16524-1-m.felsch@pengutronix.de>
[not found] ` <20190930093900.16524-12-m.felsch@pengutronix.de>
2019-10-24 11:59 ` [PATCH v11 11/15] media: tvp5150: add s_power callback Sakari Ailus
2019-11-08 10:25 ` Marco Felsch
2019-11-08 10:38 ` Sakari Ailus
[not found] ` <20190930093900.16524-5-m.felsch@pengutronix.de>
2019-11-15 23:34 ` [PATCH v11 04/15] media: v4l2-fwnode: add initial connector parsing support Sakari Ailus
2019-11-19 11:37 ` Marco Felsch
2019-11-27 8:17 ` Marco Felsch
2020-01-08 15:36 ` Marco Felsch
2020-01-09 7:07 ` Marco Felsch
2020-01-15 17:06 ` Marco Felsch [this message]
2020-02-18 12:18 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115170621.jszy2p3e4w3b3hpn@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).