From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F88DC47409 for ; Thu, 16 Jan 2020 18:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 667022051A for ; Thu, 16 Jan 2020 18:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390696AbgAPSV2 (ORCPT ); Thu, 16 Jan 2020 13:21:28 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2276 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390150AbgAPSV1 (ORCPT ); Thu, 16 Jan 2020 13:21:27 -0500 Received: from lhreml706-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id D3F0F750A9DB34BAEAB1; Thu, 16 Jan 2020 18:21:25 +0000 (GMT) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by lhreml706-cah.china.huawei.com (10.201.108.47) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 Jan 2020 18:21:25 +0000 Received: from localhost (10.202.226.57) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 16 Jan 2020 18:21:25 +0000 Date: Thu, 16 Jan 2020 18:21:24 +0000 From: Jonathan Cameron To: Matt Ranostay CC: , , Subject: Re: [PATCH v2 3/3] dt-bindings: iio: chemical: consolidate atlas-sensor docs Message-ID: <20200116182124.00006e19@Huawei.com> In-Reply-To: <20200114022348.8676-4-matt.ranostay@konsulko.com> References: <20200114022348.8676-1-matt.ranostay@konsulko.com> <20200114022348.8676-4-matt.ranostay@konsulko.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.57] X-ClientProxiedBy: lhreml733-chm.china.huawei.com (10.201.108.84) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 14 Jan 2020 04:23:48 +0200 Matt Ranostay wrote: > Since Atlas Scientific device support only varies from the compatible > string is ideal all the respective docs are merged into a single doc > named atlas,sensor.txt > > Cc: devicetree@vger.kernel.org > Signed-off-by: Matt Ranostay No chance of a yaml conversion whilst you are at it? Maybe dt maintainers will take the view this is step in the right direction and let this go, but I will want an Ack for that. > --- > .../bindings/iio/chemical/atlas,ec-sm.txt | 21 ------------ > .../bindings/iio/chemical/atlas,orp-sm.txt | 21 ------------ > .../bindings/iio/chemical/atlas,ph-sm.txt | 21 ------------ > .../bindings/iio/chemical/atlas,sensor.txt | 34 +++++++++++++++++++ > 4 files changed, 34 insertions(+), 63 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt > delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt > delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt > create mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,sensor.txt > > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt > deleted file mode 100644 > index f4320595b851..000000000000 > --- a/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -* Atlas Scientific EC-SM OEM sensor > - > -http://www.atlas-scientific.com/_files/_datasheets/_oem/EC_oem_datasheet.pdf > - > -Required properties: > - > - - compatible: must be "atlas,ec-sm" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic interrupt client > - node bindings. > - > -Example: > - > -atlas@64 { > - compatible = "atlas,ec-sm"; > - reg = <0x64>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt > deleted file mode 100644 > index af1f5a9aa4da..000000000000 > --- a/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -* Atlas Scientific ORP-SM OEM sensor > - > -https://www.atlas-scientific.com/_files/_datasheets/_oem/ORP_oem_datasheet.pdf > - > -Required properties: > - > - - compatible: must be "atlas,orp-sm" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic interrupt client > - node bindings. > - > -Example: > - > -atlas@66 { > - compatible = "atlas,orp-sm"; > - reg = <0x66>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt > deleted file mode 100644 > index 79d90f060327..000000000000 > --- a/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -* Atlas Scientific pH-SM OEM sensor > - > -http://www.atlas-scientific.com/_files/_datasheets/_oem/pH_oem_datasheet.pdf > - > -Required properties: > - > - - compatible: must be "atlas,ph-sm" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic interrupt client > - node bindings. > - > -Example: > - > -atlas@65 { > - compatible = "atlas,ph-sm"; > - reg = <0x65>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.txt > new file mode 100644 > index 000000000000..518327dc71e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.txt > @@ -0,0 +1,34 @@ > +* Atlas Scientific OEM sensors > + > +Datasheets: > + > + http://www.atlas-scientific.com/_files/_datasheets/_oem/DO_oem_datasheet.pdf > + http://www.atlas-scientific.com/_files/_datasheets/_oem/EC_oem_datasheet.pdf > + http://www.atlas-scientific.com/_files/_datasheets/_oem/ORP_oem_datasheet.pdf > + http://www.atlas-scientific.com/_files/_datasheets/_oem/pH_oem_datasheet.pdf > + > +Required properties: > + > + - compatible: must be one of : > + "atlas,do-sm", > + "atlas,ec-sm", > + "atlas,orp-sm", > + "atlas,ph-sm" > + > + - reg: the I2C address of the sensor > + > +Optional properties: > + > + - interrupts: the sole interrupt generated by the device > + > + Refer to interrupt-controller/interrupts.txt for generic interrupt client > + node bindings. > + > +Example: > + > +atlas@66 { > + compatible = "atlas,orp-sm"; > + reg = <0x66>; > + interrupt-parent = <&gpio1>; > + interrupts = <16 2>; > +};