From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D65DC35249 for ; Wed, 5 Feb 2020 09:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4558D21741 for ; Wed, 5 Feb 2020 09:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbgBEJuV (ORCPT ); Wed, 5 Feb 2020 04:50:21 -0500 Received: from mga09.intel.com ([134.134.136.24]:54130 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbgBEJuV (ORCPT ); Wed, 5 Feb 2020 04:50:21 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 01:50:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="378686508" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 05 Feb 2020 01:50:18 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1izHK8-0000R8-E9; Wed, 05 Feb 2020 11:50:20 +0200 Date: Wed, 5 Feb 2020 11:50:20 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , linux-gpio , Rob Herring , Frank Rowand , linux-devicetree , Arnd Bergmann Subject: Re: [PATCH v1] gpio: Avoid kernel.h inclusion where it's possible Message-ID: <20200205095020.GU10400@smile.fi.intel.com> References: <20200204190733.56783-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Feb 05, 2020 at 10:34:06AM +0100, Bartosz Golaszewski wrote: > wt., 4 lut 2020 o 20:07 Andy Shevchenko > napisaƂ(a): > > > > Inclusion of kernel.h increases the mess with the header dependencies. > > Avoid kernel.h inclusion where it's possible. > > > > Besides that, clean up a bit other inclusions inside GPIO subsystem headers. > > -struct pinctrl_dev; > > If this forward declaration is removed because it's no longer needed > after removing the pinctrl include, then please mention it in the > commit message. If it's unrelated then please put it in a different > patch. Will do, thanks for review! -- With Best Regards, Andy Shevchenko