devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	kernel@pengutronix.de, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org,
	Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>,
	Silvan Murer <silvan.murer@gmail.com>
Subject: Re: [PATCH 2/3] iio: dac: ltc2632: drop some duplicated data
Date: Thu, 6 Feb 2020 10:54:22 +0000	[thread overview]
Message-ID: <20200206105422.52273454@archlinux> (raw)
In-Reply-To: <20200130131549.1170-2-u.kleine-koenig@pengutronix.de>

On Thu, 30 Jan 2020 14:15:48 +0100
Uwe Kleine-König         <u.kleine-koenig@pengutronix.de> wrote:

> The channel data for ltc2632l12 and ltc2632h12 are identical. So there
> is no gain in using two different (but identical) channel descriptions.
> The only side effect of this change is some memory savings.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
> ---
>  drivers/iio/dac/ltc2632.c | 22 +++++++++-------------
>  1 file changed, 9 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
> index 643d1ce956ce..7ab92e178496 100644
> --- a/drivers/iio/dac/ltc2632.c
> +++ b/drivers/iio/dac/ltc2632.c
> @@ -192,37 +192,33 @@ static const struct iio_chan_spec_ext_info ltc2632_ext_info[] = {
>  		LTC2632_CHANNEL(1, _bits), \
>  	}
>  
> -static DECLARE_LTC2632_CHANNELS(ltc2632l12, 12);
> -static DECLARE_LTC2632_CHANNELS(ltc2632l10, 10);
> -static DECLARE_LTC2632_CHANNELS(ltc2632l8, 8);
> -
> -static DECLARE_LTC2632_CHANNELS(ltc2632h12, 12);
> -static DECLARE_LTC2632_CHANNELS(ltc2632h10, 10);
> -static DECLARE_LTC2632_CHANNELS(ltc2632h8, 8);
> +static DECLARE_LTC2632_CHANNELS(ltc2632x12, 12);
> +static DECLARE_LTC2632_CHANNELS(ltc2632x10, 10);
> +static DECLARE_LTC2632_CHANNELS(ltc2632x8, 8);
>  
>  static const struct ltc2632_chip_info ltc2632_chip_info_tbl[] = {
>  	[ID_LTC2632L12] = {
> -		.channels	= ltc2632l12_channels,
> +		.channels	= ltc2632x12_channels,
>  		.vref_mv	= 2500,
>  	},
>  	[ID_LTC2632L10] = {
> -		.channels	= ltc2632l10_channels,
> +		.channels	= ltc2632x10_channels,
>  		.vref_mv	= 2500,
>  	},
>  	[ID_LTC2632L8] =  {
> -		.channels	= ltc2632l8_channels,
> +		.channels	= ltc2632x8_channels,
>  		.vref_mv	= 2500,
>  	},
>  	[ID_LTC2632H12] = {
> -		.channels	= ltc2632h12_channels,
> +		.channels	= ltc2632x12_channels,
>  		.vref_mv	= 4096,
>  	},
>  	[ID_LTC2632H10] = {
> -		.channels	= ltc2632h10_channels,
> +		.channels	= ltc2632x10_channels,
>  		.vref_mv	= 4096,
>  	},
>  	[ID_LTC2632H8] =  {
> -		.channels	= ltc2632h8_channels,
> +		.channels	= ltc2632x8_channels,
>  		.vref_mv	= 4096,
>  	},
>  };


  reply	other threads:[~2020-02-06 10:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 13:15 [PATCH 1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support Uwe Kleine-König
2020-01-30 13:15 ` [PATCH 2/3] iio: dac: ltc2632: drop some duplicated data Uwe Kleine-König
2020-02-06 10:54   ` Jonathan Cameron [this message]
2020-01-30 13:15 ` [PATCH 3/3] iio: dac: ltc2632: add support for LTC2636 family Uwe Kleine-König
2020-02-02  9:54   ` Jonathan Cameron
2020-02-06 10:54     ` Jonathan Cameron
2020-02-02  9:52 ` [PATCH 1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support Jonathan Cameron
2020-02-06 10:42   ` Jonathan Cameron
2020-02-03 20:31 ` [PATCH 4/3] iio: dac: ltc2632: remove some unused defines Uwe Kleine-König
2020-02-06 10:29   ` Jonathan Cameron
2020-02-06 10:34     ` Uwe Kleine-König
2020-02-06 10:44       ` Jonathan Cameron
2020-02-25  9:32         ` Uwe Kleine-König
2020-03-07 11:17           ` Jonathan Cameron
2020-02-06 18:11 ` [PATCH 1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206105422.52273454@archlinux \
    --to=jic23@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.roussinbelanger@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=silvan.murer@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).