From: Jonathan Cameron <jic23@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <knaack.h@gmx.de>,
<lars@metafoo.de>, <devicetree@vger.kernel.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<pmeerw@pmeerw.net>, <linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] dt-bindings: iio: adc: sd modulator: add vref support
Date: Sat, 8 Feb 2020 16:04:54 +0000 [thread overview]
Message-ID: <20200208160454.0f153bfb@archlinux> (raw)
In-Reply-To: <20200204101008.11411-2-olivier.moysan@st.com>
On Tue, 4 Feb 2020 11:10:05 +0100
Olivier Moysan <olivier.moysan@st.com> wrote:
> Add vref supply support to sigma delta modulator.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> ---
> .../devicetree/bindings/iio/adc/sigma-delta-modulator.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> index a390343d0c2a..2afe0765e971 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> @@ -8,6 +8,7 @@ title: Device-Tree bindings for sigma delta modulator
>
> maintainers:
> - Arnaud Pouliquen <arnaud.pouliquen@st.com>
> + - Olivier Moysan <olivier.moysan@st.com>
>
> properties:
> compatible:
> @@ -21,6 +22,9 @@ properties:
> '#io-channel-cells':
> const: 0
>
> + vref-supply:
> + description: Phandle to the vref input analog reference voltage.
I note this in review of patch 2 but in general I'm not sure we should
be introducing this for generic devices. It's fine if we have an
explicit compatible but there is no reason to assume a generic sd-modulator
uses an external reference.
Jonathan
> +
> required:
> - compatible
> - '#io-channel-cells'
next prev parent reply other threads:[~2020-02-08 16:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 10:10 [PATCH 0/4] iio: adc: stm32-dfsdm: add scale and offset support Olivier Moysan
2020-02-04 10:10 ` [PATCH 1/4] dt-bindings: iio: adc: sd modulator: add vref support Olivier Moysan
2020-02-06 19:08 ` Rob Herring
2020-02-08 16:04 ` Jonathan Cameron [this message]
2020-02-11 15:24 ` Olivier MOYSAN
2020-02-04 10:10 ` [PATCH 2/4] iio: adc: sd modulator: add scale support Olivier Moysan
2020-02-08 16:03 ` Jonathan Cameron
2020-02-11 15:22 ` Olivier MOYSAN
2020-02-04 10:10 ` [PATCH 3/4] iio: adc: stm32-dfsdm: use resolution define Olivier Moysan
2020-02-04 10:10 ` [PATCH 4/4] iio: adc: stm32-dfsdm: add scale and offset support Olivier Moysan
2020-02-08 16:18 ` Jonathan Cameron
2020-02-11 15:19 ` Olivier MOYSAN
2020-02-14 13:11 ` Jonathan Cameron
2020-02-14 14:49 ` Olivier MOYSAN
2020-02-14 15:10 ` Jonathan Cameron
[not found] ` <AM9PR10MB43558CEB8DAE7F373E9E7A5DF9D69@AM9PR10MB4355.EURPRD10.PROD.OUTLOOK.COM>
2021-09-10 15:56 ` Olivier MOYSAN
2021-09-12 17:26 ` Jonathan Cameron
2021-09-14 15:43 ` Olivier MOYSAN
2021-09-19 18:14 ` Jonathan Cameron
2021-09-24 13:14 ` Olivier MOYSAN
2021-09-26 14:56 ` Jonathan Cameron
2021-09-29 16:44 ` Olivier MOYSAN
2021-09-30 15:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200208160454.0f153bfb@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=olivier.moysan@st.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).