From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/3] dt-bindings: iio: chemical: consolidate atlas-sensor docs
Date: Sat, 8 Feb 2020 16:34:58 +0000 [thread overview]
Message-ID: <20200208163458.15ec07a4@archlinux> (raw)
In-Reply-To: <20200206061332.20427-4-matt.ranostay@konsulko.com>
On Wed, 5 Feb 2020 22:13:32 -0800
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> Since Atlas Scientific device support only varies from the compatible
> string is ideal all the respective docs are merged into a single doc
> named atlas,sensor.yaml
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> ---
> .../bindings/iio/chemical/atlas,ec-sm.txt | 21 --------
> .../bindings/iio/chemical/atlas,orp-sm.txt | 21 --------
> .../bindings/iio/chemical/atlas,ph-sm.txt | 21 --------
> .../bindings/iio/chemical/atlas,sensor.yaml | 53 +++++++++++++++++++
> 4 files changed, 53 insertions(+), 63 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt
> delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt
> delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt
> deleted file mode 100644
> index f4320595b851..000000000000
> --- a/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -* Atlas Scientific EC-SM OEM sensor
> -
> -http://www.atlas-scientific.com/_files/_datasheets/_oem/EC_oem_datasheet.pdf
> -
> -Required properties:
> -
> - - compatible: must be "atlas,ec-sm"
> - - reg: the I2C address of the sensor
> - - interrupts: the sole interrupt generated by the device
> -
> - Refer to interrupt-controller/interrupts.txt for generic interrupt client
> - node bindings.
> -
> -Example:
> -
> -atlas@64 {
> - compatible = "atlas,ec-sm";
> - reg = <0x64>;
> - interrupt-parent = <&gpio1>;
> - interrupts = <16 2>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt
> deleted file mode 100644
> index af1f5a9aa4da..000000000000
> --- a/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -* Atlas Scientific ORP-SM OEM sensor
> -
> -https://www.atlas-scientific.com/_files/_datasheets/_oem/ORP_oem_datasheet.pdf
> -
> -Required properties:
> -
> - - compatible: must be "atlas,orp-sm"
> - - reg: the I2C address of the sensor
> - - interrupts: the sole interrupt generated by the device
> -
> - Refer to interrupt-controller/interrupts.txt for generic interrupt client
> - node bindings.
> -
> -Example:
> -
> -atlas@66 {
> - compatible = "atlas,orp-sm";
> - reg = <0x66>;
> - interrupt-parent = <&gpio1>;
> - interrupts = <16 2>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt
> deleted file mode 100644
> index 79d90f060327..000000000000
> --- a/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -* Atlas Scientific pH-SM OEM sensor
> -
> -http://www.atlas-scientific.com/_files/_datasheets/_oem/pH_oem_datasheet.pdf
> -
> -Required properties:
> -
> - - compatible: must be "atlas,ph-sm"
> - - reg: the I2C address of the sensor
> - - interrupts: the sole interrupt generated by the device
> -
> - Refer to interrupt-controller/interrupts.txt for generic interrupt client
> - node bindings.
> -
> -Example:
> -
> -atlas@65 {
> - compatible = "atlas,ph-sm";
> - reg = <0x65>;
> - interrupt-parent = <&gpio1>;
> - interrupts = <16 2>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml b/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml
> new file mode 100644
> index 000000000000..1b0c476838d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0
Given this is entirely your binding, would you mind using the dual
license with GPL and BSD that is preferred for new bindings?
Otherwise looks good to me.
Jonathan
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/atlas,sensor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atlas Scientific OEM sensors
> +
> +maintainers:
> + - Matt Ranostay <matt.ranostay@konsulko.com>
> +
> +description: |
> + Atlas Scientific OEM sensors connected via I2C
> +
> + Datasheets:
> + http://www.atlas-scientific.com/_files/_datasheets/_oem/DO_oem_datasheet.pdf
> + http://www.atlas-scientific.com/_files/_datasheets/_oem/EC_oem_datasheet.pdf
> + http://www.atlas-scientific.com/_files/_datasheets/_oem/ORP_oem_datasheet.pdf
> + http://www.atlas-scientific.com/_files/_datasheets/_oem/pH_oem_datasheet.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - atlas,do-sm
> + - atlas,ec-sm
> + - atlas,orp-sm
> + - atlas,ph-sm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + atlas@66 {
> + compatible = "atlas,orp-sm";
> + reg = <0x66>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <16 2>;
> + };
> + };
prev parent reply other threads:[~2020-02-08 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200206061332.20427-1-matt.ranostay@konsulko.com>
2020-02-06 6:13 ` [PATCH v4 3/3] dt-bindings: iio: chemical: consolidate atlas-sensor docs Matt Ranostay
2020-02-06 21:52 ` Rob Herring
2020-02-08 16:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200208163458.15ec07a4@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).