From: Tao Ren <rentao.bupt@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Joel Stanley <joel@jms.id.au>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Jeffery <andrew@aj.id.au>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Colin Ian King <colin.king@canonical.com>,
Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH 2/3] usb: gadget: aspeed: add ast2600 vhub support
Date: Mon, 10 Feb 2020 11:31:29 -0800 [thread overview]
Message-ID: <20200210193128.GC5346@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <b7bf421b5fad397a7ef430af6c0c09602dd66c2a.camel@kernel.crashing.org>
On Mon, Feb 10, 2020 at 08:29:22AM +0100, Benjamin Herrenschmidt wrote:
> On Mon, 2020-02-10 at 02:48 +0000, Joel Stanley wrote:
> > On Fri, 31 Jan 2020 at 22:22, <rentao.bupt@gmail.com> wrote:
> > >
> > > From: Tao Ren <rentao.bupt@gmail.com>
> > >
> > > Add AST2600 support in aspeed-vhub driver. There are 3 major differences
> > > between AST2500 and AST2600 vhub:
> > > - AST2600 supports 7 downstream ports while AST2500 supports 5.
> > > - AST2600 supports 21 generic endpoints while AST2500 supports 15.
> > > - EP0 data buffer's 8-byte DMA alignment restriction is removed from
> > > AST2600.
> > >
> > > Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
> > > Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> Travelling at the moment so my review might be a bit delayed. Also for
> some reason I missed your original submission, sorry about that, please
> poke me next time if I don't reply within a couple of days !
No worries Ben and thanks for the review. I thought people was too busy
during merge window :)
>
> One thing to look into as well is the 2600 has revived the "device
> controller" which looks like a cut down version of a vhub device, so we
> should break a bit more the linkage between vhub and the underlying
> devices so the latter can be instanciated standalone...
>
> (Foor for thought, I'm not asking you to do that right now)
Thanks for sharing your thought. I was actually curious why "device
controller" was back. Anyways I feel it might be easier to break the
linkage when we decide to add driver for the "device controller".
Cheers,
Tao
>
> Cheers,
> Ben.
>
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> >
> > > ---
> > > drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 4 ++--
> > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 9 +++++++++
> > > 2 files changed, 11 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
> > > index 83ba8a2eb6af..605500b19cf3 100644
> > > --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
> > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
> > > @@ -4,5 +4,5 @@ config USB_ASPEED_VHUB
> > > depends on ARCH_ASPEED || COMPILE_TEST
> > > depends on USB_LIBCOMPOSITE
> > > help
> > > - USB peripheral controller for the Aspeed AST2500 family
> > > - SoCs supporting the "vHub" functionality and USB2.0
> > > + USB peripheral controller for the Aspeed AST2400, AST2500 and
> > > + AST2600 family SoCs supporting the "vHub" functionality and USB2.0
> > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c
> > > index 94081cc04113..c827bf420278 100644
> > > --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c
> > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c
> > > @@ -42,6 +42,11 @@ static const struct ast_vhub_config ast2400_config = {
> > > .max_epns = 15,
> > > };
> > >
> > > +static const struct ast_vhub_config ast2600_config = {
> > > + .max_ports = 7,
> > > + .max_epns = 21,
> > > +};
> > > +
> > > static const struct of_device_id ast_vhub_dt_ids[] = {
> > > {
> > > .compatible = "aspeed,ast2400-usb-vhub",
> > > @@ -51,6 +56,10 @@ static const struct of_device_id ast_vhub_dt_ids[] = {
> > > .compatible = "aspeed,ast2500-usb-vhub",
> > > .data = &ast2400_config,
> > > },
> > > + {
> > > + .compatible = "aspeed,ast2600-usb-vhub",
> > > + .data = &ast2600_config,
> > > + },
> > > { }
> > > };
> > > MODULE_DEVICE_TABLE(of, ast_vhub_dt_ids);
> > > --
> > > 2.17.1
> > >
>
next prev parent reply other threads:[~2020-02-10 19:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 22:21 [PATCH 0/3] aspeed-g6: enable usb support rentao.bupt
2020-01-31 22:21 ` [PATCH 1/3] usb: gadget: aspeed: read vhub config from of_device_id rentao.bupt
2020-02-10 2:47 ` Joel Stanley
2020-02-10 7:27 ` Benjamin Herrenschmidt
2020-02-10 19:07 ` Tao Ren
2020-02-11 8:50 ` Benjamin Herrenschmidt
2020-02-12 2:37 ` Tao Ren
2020-02-10 19:16 ` Tao Ren
2020-01-31 22:21 ` [PATCH 2/3] usb: gadget: aspeed: add ast2600 vhub support rentao.bupt
2020-02-10 2:48 ` Joel Stanley
2020-02-10 7:29 ` Benjamin Herrenschmidt
2020-02-10 19:31 ` Tao Ren [this message]
2020-01-31 22:21 ` [PATCH 3/3] ARM: dts: aspeed-g6: add usb functions rentao.bupt
2020-02-10 2:47 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210193128.GC5346@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=andrew@aj.id.au \
--cc=balbi@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=chunfeng.yun@mediatek.com \
--cc=colin.king@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).