From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E5EC352A3 for ; Tue, 11 Feb 2020 11:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6FC120714 for ; Tue, 11 Feb 2020 11:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HsqMyuSs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728011AbgBKLH3 (ORCPT ); Tue, 11 Feb 2020 06:07:29 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:46568 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727264AbgBKLH3 (ORCPT ); Tue, 11 Feb 2020 06:07:29 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C7ECE52A; Tue, 11 Feb 2020 12:07:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1581419247; bh=pBTt/u7T3z2+TO23AZgfk6mLR2REE3Psxm7jHS2oWcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HsqMyuSsu9+ikDDmWp1U+jfXsGr4562qnPs5W9HoPv9TbJB3kxOWl0cr4TFB9bV37 +O5Fzr7CsRL2YLhwH1Wz0bYHnM5BfRrI5/OiGon4UWZKdJp2rrHCars+lEnMK42ct4 dZRZRDKzw3MwOC5PQKA8hI3TzMJ4qkaIo1jTR45s= Date: Tue, 11 Feb 2020 13:07:12 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Tony Lindgren , Linux-OMAP , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Thierry Reding , Jyri Sarha , Peter Ujfalusi Subject: Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings Message-ID: <20200211110712.GB28355@pendragon.ideasonboard.com> References: <20191114093950.4101-1-tomi.valkeinen@ti.com> <20191114093950.4101-3-tomi.valkeinen@ti.com> <20191202130459.GH4929@pendragon.ideasonboard.com> <20191211165331.GC43123@atomide.com> <45dae8f7-2f5e-6948-5a05-dc8a09ace1fa@ti.com> <20191212203550.GB4892@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tomi, On Tue, Feb 11, 2020 at 12:01:31PM +0200, Tomi Valkeinen wrote: > On 13/01/2020 14:01, Tomi Valkeinen wrote: > > On 12/12/2019 22:35, Laurent Pinchart wrote: > >> On Thu, Dec 12, 2019 at 11:37:51AM +0200, Tomi Valkeinen wrote: > >>> On 11/12/2019 18:53, Tony Lindgren wrote: > >>>> * Laurent Pinchart [191202 13:05]: > >>>>> Hi Tomi, > >>>>> > >>>>> Thank you for the patch. > >>>>> > >>>>> On Thu, Nov 14, 2019 at 11:39:49AM +0200, Tomi Valkeinen wrote: > >>>>>> panel-simple now handled panel osd070t1718-19ts, and we no longer need > >>>>>> the panel timings in the DT file. So remove them. > >>>>> > >>>>> Should you in that case drop the panel-dpi compatible string too, as the > >>>>> panel-dpi bindings require panel timings in DT ? > >>>> > >>>> Yeah sounds like if panel-dpi is no longer usable for this device it > >>>> should be dropped from the compatible list. > >>> > >>> Ok, I agree. > >>> > >>> Looking at the dts files, panel-dpi is used in a bunch of boards. But > >>> we even have 3 dts files with panel-dpi, without the detailed panel > >>> model in compatible... > >>> > >>> Fixing those will break the compatibility with old dtbs and new > >>> kernel, unless we add timings-from-dt to a panel driver that handles > >>> panel-dpi. > >> > >> I know, and I don't have a perfect answer for this :-( I don't see a > >> third option, it's either breaking DT backward compatibility or adding > >> timings parsing to a panel driver (either a new panel-dpi driver or to > >> panel-simple). What's your preferred option ? > > > > Hmm, I just realized that changing these will break omapfb. It > > relies on panel-dpi and timings from DT... > > If no one objects, I think we should just drop the timings from the > .dts, and say that these boards are no longer supported with omapfb. I > don't think there's much point in trying to keep omapfb working fine > for boards that are fully supported by omapdrm. No objection from me. > Hopefully soon (in five years? =) we can say that omapdrm supports all > the boards, and we can deprecate omapfb. I'd love to send a patch to remove omapfb, but I'll let you do the honours :-) -- Regards, Laurent Pinchart