From: George Hilliard <ghilliard@kopismobile.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: George Hilliard <ghilliard@kopismobile.com>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
kernel@pengutronix.de
Subject: [PATCH v3 2/2] tty: imx serial: Implement support for reversing TX and RX polarity
Date: Wed, 12 Feb 2020 10:35:38 -0600 [thread overview]
Message-ID: <20200212163538.3006-3-ghilliard@kopismobile.com> (raw)
In-Reply-To: <20200212163538.3006-1-ghilliard@kopismobile.com>
The peripheral has support for inverting its input and/or output
signals. This is useful if the hardware flips polarity of the
peripheral's signal, such as swapped +/- pins on an RS-422 transceiver,
or an inverting level shifter. Add support for these control registers
via the device tree binding.
Signed-off-by: George Hilliard <ghilliard@kopismobile.com>
---
v1..v2: Remove confidentiality spam
v2..v3: Set *and* clear register, and do it before TX enable
drivers/tty/serial/imx.c | 28 +++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 0c6c63166250..205627bcad66 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -195,6 +195,8 @@ struct imx_port {
unsigned int have_rtscts:1;
unsigned int have_rtsgpio:1;
unsigned int dte_mode:1;
+ unsigned int inverted_tx:1;
+ unsigned int inverted_rx:1;
struct clk *clk_ipg;
struct clk *clk_per;
const struct imx_uart_data *devdata;
@@ -1335,7 +1337,7 @@ static int imx_uart_startup(struct uart_port *port)
int retval, i;
unsigned long flags;
int dma_is_inited = 0;
- u32 ucr1, ucr2, ucr4;
+ u32 ucr1, ucr2, ucr3, ucr4;
retval = clk_prepare_enable(sport->clk_per);
if (retval)
@@ -1390,8 +1392,22 @@ static int imx_uart_startup(struct uart_port *port)
ucr4 = imx_uart_readl(sport, UCR4) & ~UCR4_OREN;
if (!sport->dma_is_enabled)
ucr4 |= UCR4_OREN;
+ if (sport->inverted_rx)
+ ucr4 |= UCR4_INVR;
+ else
+ ucr4 &= ~UCR4_INVR;
imx_uart_writel(sport, ucr4, UCR4);
+ /*
+ * configure tx polarity before enabling tx
+ */
+ ucr3 = imx_uart_readl(sport, UCR3);
+ if (sport->inverted_tx)
+ ucr3 |= UCR3_INVT;
+ else
+ ucr3 &= ~UCR3_INVT;
+ imx_uart_writel(sport, ucr3, UCR3);
+
ucr2 = imx_uart_readl(sport, UCR2) & ~UCR2_ATEN;
ucr2 |= (UCR2_RXEN | UCR2_TXEN);
if (!sport->have_rtscts)
@@ -1405,10 +1421,6 @@ static int imx_uart_startup(struct uart_port *port)
imx_uart_writel(sport, ucr2, UCR2);
if (!imx_uart_is_imx1(sport)) {
- u32 ucr3;
-
- ucr3 = imx_uart_readl(sport, UCR3);
-
ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
if (sport->dte_mode)
@@ -2184,6 +2196,12 @@ static int imx_uart_probe_dt(struct imx_port *sport,
if (of_get_property(np, "rts-gpios", NULL))
sport->have_rtsgpio = 1;
+ if (of_get_property(np, "fsl,inverted-tx", NULL))
+ sport->inverted_tx = 1;
+
+ if (of_get_property(np, "fsl,inverted-rx", NULL))
+ sport->inverted_rx = 1;
+
return 0;
}
#else
--
2.25.0
next prev parent reply other threads:[~2020-02-12 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 16:35 [PATCH v3 0/2] Implement support for inverted serial TX/RX on i.MX George Hilliard
2020-02-12 16:35 ` [PATCH v3 1/2] dt-bindings: serial: document fsl,inverted-tx and -rx options George Hilliard
2020-02-18 23:07 ` Rob Herring
2020-02-12 16:35 ` George Hilliard [this message]
2020-02-12 20:47 ` [PATCH v3 2/2] tty: imx serial: Implement support for reversing TX and RX polarity Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212163538.3006-3-ghilliard@kopismobile.com \
--to=ghilliard@kopismobile.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).