From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
kbuild test robot <lkp@intel.com>
Subject: [PATCH 3/5] ASoC: meson: aiu: fix irq registration
Date: Fri, 14 Feb 2020 14:13:48 +0100 [thread overview]
Message-ID: <20200214131350.337968-4-jbrunet@baylibre.com> (raw)
In-Reply-To: <20200214131350.337968-1-jbrunet@baylibre.com>
The aiu stored the irq in an unsigned integer which may have discarded an
error returned by platform_get_irq_byname(). This is incorrect and should
have been a signed integer.
Also drop the irq error traces from the probe function as this is already
done by platform_get_irq_byname().
Fixes: 6ae9ca9ce986 ("ASoC: meson: aiu: add i2s and spdif support")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
sound/soc/meson/aiu.c | 8 ++------
sound/soc/meson/aiu.h | 2 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c
index de678a9d5cab..34b40b8b8299 100644
--- a/sound/soc/meson/aiu.c
+++ b/sound/soc/meson/aiu.c
@@ -314,16 +314,12 @@ static int aiu_probe(struct platform_device *pdev)
}
aiu->i2s.irq = platform_get_irq_byname(pdev, "i2s");
- if (aiu->i2s.irq < 0) {
- dev_err(dev, "Can't get i2s irq\n");
+ if (aiu->i2s.irq < 0)
return aiu->i2s.irq;
- }
aiu->spdif.irq = platform_get_irq_byname(pdev, "spdif");
- if (aiu->spdif.irq < 0) {
- dev_err(dev, "Can't get spdif irq\n");
+ if (aiu->spdif.irq < 0)
return aiu->spdif.irq;
- }
ret = aiu_clk_get(dev);
if (ret)
diff --git a/sound/soc/meson/aiu.h b/sound/soc/meson/aiu.h
index a65a576e3400..097c26de7b7c 100644
--- a/sound/soc/meson/aiu.h
+++ b/sound/soc/meson/aiu.h
@@ -26,7 +26,7 @@ enum aiu_clk_ids {
struct aiu_interface {
struct clk_bulk_data *clks;
unsigned int clk_num;
- unsigned int irq;
+ int irq;
};
struct aiu {
--
2.24.1
next prev parent reply other threads:[~2020-02-14 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:13 [PATCH 0/5] ASoC: meson: aiu: fixups Jerome Brunet
2020-02-14 13:13 ` [PATCH 1/5] ASoC: meson: aiu: remove unused encoder structure Jerome Brunet
2020-02-14 20:56 ` Applied "ASoC: meson: aiu: remove unused encoder structure" to the asoc tree Mark Brown
2020-02-14 13:13 ` [PATCH 2/5] ASoC: meson: aiu: fix clk bulk size allocation Jerome Brunet
2020-02-14 20:56 ` Applied "ASoC: meson: aiu: fix clk bulk size allocation" to the asoc tree Mark Brown
2020-02-14 13:13 ` Jerome Brunet [this message]
2020-02-14 20:56 ` Applied "ASoC: meson: aiu: fix irq registration" " Mark Brown
2020-02-14 13:13 ` [PATCH 4/5] ASoC: meson: aiu: fix acodec dai input name init Jerome Brunet
2020-02-14 20:56 ` Applied "ASoC: meson: aiu: fix acodec dai input name init" to the asoc tree Mark Brown
2020-02-14 13:13 ` [PATCH 5/5] ASoC: meson: codec-glue: fix pcm format cast warning Jerome Brunet
2020-02-14 20:56 ` Applied "ASoC: meson: codec-glue: fix pcm format cast warning" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214131350.337968-4-jbrunet@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).