From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06BAAC2BA83 for ; Fri, 14 Feb 2020 13:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDA192187F for ; Fri, 14 Feb 2020 13:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581686534; bh=GD8k65h3tvI8piTI2dwKcrWso9hPL3kxwyOa3aWsOQs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=G3T1Adamm+xBR7g8lbg5q9Bb8moqso/2qSb8G8C7ou6sGdyD+Fd94aX0Crq6eolOW kCZ5yBITtpbdXLGRuhD/1D/2a7sOjfUR8lNxFuO+S15+2e6BfRke0HehSDZKLkV4EM HIaxgAXv5ZvZUtIn/hMCvKt3HwEDoGa5nMUYyu6Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728121AbgBNNWO (ORCPT ); Fri, 14 Feb 2020 08:22:14 -0500 Received: from foss.arm.com ([217.140.110.172]:33038 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgBNNWO (ORCPT ); Fri, 14 Feb 2020 08:22:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A70E61FB; Fri, 14 Feb 2020 05:22:13 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2ABF23F68F; Fri, 14 Feb 2020 05:22:13 -0800 (PST) Date: Fri, 14 Feb 2020 13:22:11 +0000 From: Mark Brown To: Jerome Brunet Cc: Liam Girdwood , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Kevin Hilman Subject: Re: [PATCH 5/9] ASoC: meson: aiu: add hdmi codec control support Message-ID: <20200214132211.GK4827@sirena.org.uk> References: <20200213155159.3235792-1-jbrunet@baylibre.com> <20200213155159.3235792-6-jbrunet@baylibre.com> <20200213182157.GJ4333@sirena.org.uk> <1j36bdfgx1.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QxIEt88oQPsT6QmF" Content-Disposition: inline In-Reply-To: <1j36bdfgx1.fsf@starbuckisacylon.baylibre.com> X-Cookie: Shipping not included. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --QxIEt88oQPsT6QmF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 14, 2020 at 02:16:10PM +0100, Jerome Brunet wrote: > On Thu 13 Feb 2020 at 19:21, Mark Brown wrote: > >> +#ifdef CONFIG_DEBUG_FS > >> + component->debugfs_prefix = debugfs_prefix; > >> +#endif > > You really shouldn't be doing this as it could conflict with something > > the machine driver wants to do however it's probably not going to be an > > issue in practice as it's not like there's going to be multiple SoCs in > > the card at once and if there were there'd doubltess be other issues. > I'm not sure I understand (and I'd prefer to :) ) > As you said before, initially the there was supposed to be a 1:1 mapping > between device and component. The component name is directly derived > from the device name, and the debugfs directory is created from component name. I understand why you're doing it but that feature is intended for the use of cards when they're integrating components, not for devices trying to register multiple components on the same device. This means that a card that tries to use the feature will conflict with what the driver is doing, but like I say there's no obvious use case for a card doing that. > Instead of addressing the debugfs side effect, maybe we could just make > sure that each component name is unique within ASoC ? I'd be happy submit > something if you think this can helpful. That'd be better. --QxIEt88oQPsT6QmF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5GnwIACgkQJNaLcl1U h9ConAf/ZGIifJ2A3GT7/6hgGBOd30DCPyZ8wpzAq0wHv/ihVoH/uLJqlLiRVglQ Nqx0WU3HNlkMaHwiGc/1rp2fiXdZ1hzXQsCcHMX+0vQyLVRqtsITAVkHauL9RVE8 U+DlOVSjkI7k4jPw9NQgATNCA0a5cw1WMzorwS6WNeLMUS3eqQdqxBZeLgwTqtdz zRg9Fwb/c9xmCJgQ8PdybSvDTxW0G9Mx/0BWAfeJqSUTk/2tQjpODkaGQP1fH/Az keB6n64qi+KoaIGZNUVEfiLL2zJ0w49nfDKyb1n5KndN0+iOVbk9jxRtnDaGajYF /ZLH5B59EjOw9RfRJTsAvNs2GO8JIA== =YJRb -----END PGP SIGNATURE----- --QxIEt88oQPsT6QmF--