From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
Anson.Huang@nxp.com, devicetree@vger.kernel.org, kernel@puri.sm,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Angus Ainslie (Purism)" <angus@akkea.ca>
Subject: Re: [PATCH v1 03/12] arm64: dts: librem5-devkit: allow modem to wake the system from suspend
Date: Mon, 17 Feb 2020 12:02:17 +0800 [thread overview]
Message-ID: <20200217040216.GD5395@dragon> (raw)
In-Reply-To: <20200205143003.28408-4-martin.kepplinger@puri.sm>
On Wed, Feb 05, 2020 at 03:29:54PM +0100, Martin Kepplinger wrote:
> From: "Angus Ainslie (Purism)" <angus@akkea.ca>
>
> Connect the WoWWAN signal to a gpio key to wake up the system from suspend.
>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
> .../dts/freescale/imx8mq-librem5-devkit.dts | 27 +++++++++++++++----
> 1 file changed, 22 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 8162576e8f3d..ac6ba227e1da 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -33,7 +33,7 @@
> gpio-keys {
> compatible = "gpio-keys";
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_gpio_keys>;
> + pinctrl-0 = <&pinctrl_gpio_keys>, <&pinctrl_wwan_in>;
>
> btn1 {
> label = "VOL_UP";
> @@ -55,6 +55,15 @@
> wakeup-source;
> linux,code = <KEY_HP>;
> };
> +
> + wwan_wake {
> + label = "WWAN_WAKE";
> + gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <8 GPIO_ACTIVE_LOW>;
> + wakeup-source;
> + linux,code = <KEY_PHONE>;
> + };
> };
>
> leds {
> @@ -767,11 +776,19 @@
> >;
> };
>
> - pinctrl_wwan: wwangrp {
> + pinctrl_wwan_in: wwaningrp {
> + fsl,pins = <
> + /* nWoWWAN */
> + MX8MQ_IOMUXC_NAND_DATA02_GPIO3_IO8 0x80
Why not just add it to pinctrl_gpio_keys to make the change minimal.
> + >;
> + };
> +
> + pinctrl_wwan_out: wwanoutgrp {
> fsl,pins = <
> - MX8MQ_IOMUXC_NAND_CE3_B_GPIO3_IO4 0x09 /* nWWAN_DISABLE */
> - MX8MQ_IOMUXC_NAND_DATA02_GPIO3_IO8 0x80 /* nWoWWAN */
> - MX8MQ_IOMUXC_NAND_DATA03_GPIO3_IO9 0x19 /* WWAN_RESET */
> + /* nWWAN_DISABLE */
> + MX8MQ_IOMUXC_NAND_CE3_B_GPIO3_IO4 0x09
> + /* WWAN_RESET */
> + MX8MQ_IOMUXC_NAND_DATA03_GPIO3_IO9 0x19
Unnecessary changes.
Shawn
> >;
> };
> };
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-02-17 4:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 14:29 [PATCH v1 00/12] arm64: dts: librem5-devkit: description updates Martin Kepplinger
2020-02-05 14:29 ` [PATCH v1 01/12] arm64: dts: librem5-devkit: add sai2 and sai6 pinctrl definitions Martin Kepplinger
2020-02-17 3:54 ` Shawn Guo
2020-02-05 14:29 ` [PATCH v1 02/12] arm64: dts: librem5-devkit: add the simcom 7100 modem and audio Martin Kepplinger
2020-02-17 3:59 ` Shawn Guo
2020-02-05 14:29 ` [PATCH v1 03/12] arm64: dts: librem5-devkit: allow modem to wake the system from suspend Martin Kepplinger
2020-02-17 4:02 ` Shawn Guo [this message]
2020-02-05 14:29 ` [PATCH v1 04/12] arm64: dts: librem5-devkit: enable sai2 audio interface Martin Kepplinger
2020-02-05 14:29 ` [PATCH v1 05/12] arm64: dts: librem5-devkit: add the sgtl5000 i2c audio codec Martin Kepplinger
2020-02-17 4:05 ` Shawn Guo
2020-02-05 14:29 ` [PATCH v1 06/12] arm64: dts: librem5-devkit: add a vbus supply to usb0 Martin Kepplinger
2020-02-05 14:29 ` [PATCH v1 07/12] arm64: dts: librem5-devkit: add the regulators for DVFS Martin Kepplinger
2020-02-17 4:08 ` Shawn Guo
2020-02-05 14:29 ` [PATCH v1 08/12] arm64: dts: librem5-devkit: add a battery for the bq25896 to monitor Martin Kepplinger
2020-02-05 14:30 ` [PATCH v1 09/12] arm64: dts: librem5-devkit: allow the redpine card to be removed Martin Kepplinger
2020-02-05 14:30 ` [PATCH v1 10/12] arm64: dts: librem5-devkit: configure VSELECT Martin Kepplinger
2020-02-17 4:09 ` Shawn Guo
2020-02-05 14:30 ` [PATCH v1 11/12] arm64: dts: librem5-devkit: increase the VBUS current in the kernel Martin Kepplinger
2020-02-05 14:30 ` [PATCH v1 12/12] arm64: dts: librem5-devkit: add lsm9ds1 mount matrix Martin Kepplinger
2020-02-13 14:08 ` [PATCH v1 00/12] arm64: dts: librem5-devkit: description updates Martin Kepplinger
2020-02-14 18:44 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217040216.GD5395@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.kepplinger@puri.sm \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).