From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4AFC34022 for ; Mon, 17 Feb 2020 16:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 498072072C for ; Mon, 17 Feb 2020 16:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581956815; bh=rF5n1LALgS1QdHMLdIt6JdEOXWZA/nrceOeMB/9wLqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pPC8aukRHRjEDbbVBoo98SQ1SeqHuQuge2+Zdv9QRf7FEUoLGCtIIngI5S1eHOkpo KPxfmf9+dNV2LzZPpLBiflGtz6zCrcAY/ELy2J8+AYkm5P8w2sFzvX7EZrLrUo/7bf Cx2A9Z9YcBoqol1/yDYhSR0CfZDdQ8lLIHBCr2h4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728463AbgBQQ0y (ORCPT ); Mon, 17 Feb 2020 11:26:54 -0500 Received: from foss.arm.com ([217.140.110.172]:38182 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727922AbgBQQ0y (ORCPT ); Mon, 17 Feb 2020 11:26:54 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3729C30E; Mon, 17 Feb 2020 08:26:54 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD9143F68F; Mon, 17 Feb 2020 08:26:53 -0800 (PST) Date: Mon, 17 Feb 2020 16:26:52 +0000 From: Mark Brown To: Samuel Holland Cc: Liam Girdwood , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Vasily Khoruzhick , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/34] sun8i-codec fixes and new features Message-ID: <20200217162652.GO9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jozmn01XJZjDjM3N" Content-Disposition: inline In-Reply-To: <20200217064250.15516-1-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --jozmn01XJZjDjM3N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:16AM -0600, Samuel Holland wrote: > There are several trivial fixes in here, and there are several commits > that just add new features without changing any existing behavior, but > there is enough changing that I thought it would be best to send the > whole thing as an RFC. I'm more than happy to reorganize this into one > or several patchsets in future revisions. It doesn't have to all go in > at once. This could definitely use being both split up and reordered, it's a 34 patch series as things stand which is just far too big and I don't understand the ordering within the series - there's a mix of fixes, cleanups and new features which should come in that order but don't. This makes it difficult to get a handle on what's going on because what the series is doing jumps about a lot. There's also a lot of overuse of fixes tags and stable tags which also makes things less clear. I'd suggest first sending all the clear fixes as a separate series with the cleanups and new functionality separate. With regard to the ABI breaks they *may* be OK for mainline if we're confident that there's not going to be anyone broken by them but we should be looking to maintain compatibility if we can even if that's the case. --jozmn01XJZjDjM3N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KvssACgkQJNaLcl1U h9AFkAf+PTXKlVW0kwCz5ifw7rANYaEVuHbffAG8xTZ4xnAb6OOQp6nrRyjbeCh+ CVeQiWco9iMv0s3ViZrPNRu0cAY0q5yT9/3PtcSUnf9kdZU0j2NGgVcd8M1r36nG rqo32+9t3pM7PVuMFxprSYIWowjL4imVnijbUr4HKqMfgcSv11/A8/vrgeFDVw7s iaICzpZ7eEo7wz23UocFb3ZTLamvSqlUen7jJj8l2KlMZute7NlbH9WOZVV7KHoE i/eafDrmflwnVDqYffboBROuzLF3fBWbcvyBHsqt9ox5N4YIv9+IBp9u1JORKCPX tAZBXTMe3EN10DSbE3X0iXvk+gwzRw== =106H -----END PGP SIGNATURE----- --jozmn01XJZjDjM3N--