From: Mark Brown <broonie@kernel.org>
To: "Ramuthevar,
Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
vigneshr@ti.com, mark.rutland@arm.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, dan.carpenter@oracle.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v9 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller
Date: Mon, 17 Feb 2020 17:09:01 +0000 [thread overview]
Message-ID: <20200217170901.GS9304@sirena.org.uk> (raw)
In-Reply-To: <3530edcd-eb67-8ea5-0fce-89c83400441c@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Mon, Feb 17, 2020 at 05:18:10PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 14/2/2020 9:09 PM, Mark Brown wrote:
> > This will unconditionally handle the interrupt regardless of if the
> > hardware was actually flagging an interrupt which will break shared
> > interrupts and the fault handling code in genirq.
> Yes, you're correct, it doesn't check unconditionally, will update the
> INT flag in the INT_STATUS register after successful completion of
> read/write operation.
> but in this case it is dedicated to qspi-interrupt,not shared with any other
> HW/SW interrupts.
Currently, on the system you're looking at. Given that this is already
a widely reused IP there's no guarantee that this will always be the
case, and like I say even without sharing it also defeats the fault
handling code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-17 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 11:46 [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
2020-02-14 14:08 ` Mark Brown
2020-02-14 11:46 ` [PATCH v9 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-14 13:09 ` Mark Brown
2020-02-17 9:18 ` Ramuthevar, Vadivel MuruganX
2020-02-17 17:09 ` Mark Brown [this message]
2020-02-18 3:17 ` Ramuthevar, Vadivel MuruganX
2020-02-14 12:02 ` [PATCH v9 0/2] " Simon Goldschmidt
2020-02-14 12:11 ` Mark Brown
2020-02-14 12:50 ` Simon Goldschmidt
2020-02-14 13:15 ` Mark Brown
2020-02-14 13:49 ` Simon Goldschmidt
2020-02-14 14:16 ` Mark Brown
2020-02-17 10:09 ` Ramuthevar, Vadivel MuruganX
[not found] ` <4712cdc4-34cd-990b-3d53-3d394ae1250b@linux.intel.com>
2020-02-17 11:52 ` Mark Brown
2020-02-17 12:18 ` Vignesh Raghavendra
2020-02-18 8:56 ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:11 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217170901.GS9304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).