From: Rob Herring <robh@kernel.org>
To: matthias.bgg@kernel.org
Cc: mark.rutland@arm.com, ck.hu@mediatek.com, p.zabel@pengutronix.de,
airlied@linux.ie, mturquette@baylibre.com, sboyd@kernel.org,
ulrich.hecht+renesas@gmail.com,
laurent.pinchart@ideasonboard.com, enric.balletbo@collabora.com,
devicetree@vger.kernel.org, drinkcat@chromium.org,
frank-w@public-files.de, sean.wang@mediatek.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
wens@csie.org, linux-mediatek@lists.infradead.org,
rdunlap@infradead.org, hsinyi@chromium.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, Matthias Brugger <mbrugger@suse.com>,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v7 02/13] dt-bindings: display: mediatek: Add mmsys binding description
Date: Tue, 18 Feb 2020 14:31:51 -0600 [thread overview]
Message-ID: <20200218203151.GA15948@bogus> (raw)
In-Reply-To: <20200213201953.15268-3-matthias.bgg@kernel.org>
On Thu, Feb 13, 2020 at 09:19:42PM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> The MediaTek DRM has a block called mmsys, which sets
> the routing and enables the different blocks.
> This patch adds one line for the mmsys bindings description and changes
> the mmsys description to use the generic form of referring to a specific
> Soc.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> Changes in v7:
> - add hint to the mmsys binding document
> - make mmsys description generic
> - fix typo in commit message
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> .../bindings/display/mediatek/mediatek,disp.txt | 3 +++
> .../bindings/display/mediatek/mediatek,mmsys.txt | 9 +--------
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index b91e709db7a4..8e453026ef78 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -24,6 +24,7 @@ connected to.
> For a description of the display interface sink function blocks, see
> Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt and
> Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt.
> +Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt.
>
> Required properties (all function blocks):
> - compatible: "mediatek,<chip>-disp-<function>", one of
> @@ -43,7 +44,9 @@ Required properties (all function blocks):
> "mediatek,<chip>-dpi" - DPI controller, see mediatek,dpi.txt
> "mediatek,<chip>-disp-mutex" - display mutex
> "mediatek,<chip>-disp-od" - overdrive
> + "mediatek,<chip>-mmsys", "syscon" - provide clocks and components management
> the supported chips are mt2701, mt2712 and mt8173.
> +
> - reg: Physical base address and length of the function block register space
> - interrupts: The interrupt signal from the function block (required, except for
> merge and split function blocks).
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt
> index 301eefbe1618..7bbadee820e3 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mmsys.txt
> @@ -5,14 +5,7 @@ The Mediatek mmsys controller provides various clocks to the system.
>
> Required Properties:
>
> -- compatible: Should be one of:
> - - "mediatek,mt2701-mmsys", "syscon"
> - - "mediatek,mt2712-mmsys", "syscon"
> - - "mediatek,mt6779-mmsys", "syscon"
> - - "mediatek,mt6797-mmsys", "syscon"
> - - "mediatek,mt7623-mmsys", "mediatek,mt2701-mmsys", "syscon"
You've lost this information about the fallback...
> - - "mediatek,mt8173-mmsys", "syscon"
> - - "mediatek,mt8183-mmsys", "syscon"
> +- compatible: "mediatek,<chip>-mmsys"
You are just going to have to add these all back when this is converted
to schema.
Rob
next prev parent reply other threads:[~2020-02-18 20:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:19 [PATCH v7 00/13] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg
2020-02-13 20:19 ` [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display matthias.bgg
2020-02-14 6:42 ` CK Hu
2020-02-14 10:01 ` Matthias Brugger
2020-02-14 12:19 ` Enric Balletbo i Serra
2020-02-14 16:22 ` CK Hu
2020-02-13 20:19 ` [PATCH v7 02/13] dt-bindings: display: mediatek: Add mmsys binding description matthias.bgg
2020-02-18 20:31 ` Rob Herring [this message]
2020-02-13 20:19 ` [PATCH v7 03/13] dt-bindings: mediatek: Add compatible for mt7623 matthias.bgg
2020-02-13 20:19 ` [PATCH v7 04/13] drm/mediatek: Use regmap for register access matthias.bgg
2020-02-13 20:19 ` [PATCH v7 05/13] drm: mediatek: Omit warning on probe defers matthias.bgg
2020-02-13 20:19 ` [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get matthias.bgg
2020-02-24 17:36 ` Hans Verkuil
2020-02-24 21:47 ` Matthias Brugger
2020-02-13 20:19 ` [PATCH v7 07/13] clk: mediatek: mt2701: switch mmsys to platform device probing matthias.bgg
2020-02-13 20:19 ` [PATCH v7 08/13] clk: mediatek: mt2712e: switch " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 09/13] clk: mediatek: mt6779: switch mmsys " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 10/13] clk: mediatek: mt6797: switch " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 11/13] clk: mediatek: mt8183: switch mmsys " matthias.bgg
2020-02-14 1:52 ` CK Hu
2020-02-13 20:19 ` [PATCH v7 12/13] clk: mediatek: mt8173: " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 13/13] drm/mediatek: Add support for mmsys through a pdev matthias.bgg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218203151.GA15948@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).