From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C63EC3F2C6 for ; Tue, 3 Mar 2020 10:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFECB2187F for ; Tue, 3 Mar 2020 10:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727862AbgCCKJi (ORCPT ); Tue, 3 Mar 2020 05:09:38 -0500 Received: from mga05.intel.com ([192.55.52.43]:21993 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727820AbgCCKJi (ORCPT ); Tue, 3 Mar 2020 05:09:38 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 02:09:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,510,1574150400"; d="scan'208";a="351792132" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 03 Mar 2020 02:09:34 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j94Ua-006WAi-JV; Tue, 03 Mar 2020 12:09:36 +0200 Date: Tue, 3 Mar 2020 12:09:36 +0200 From: Andy Shevchenko To: "Tanwar, Rahul" Cc: Randy Dunlap , mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, rtanwar Subject: Re: [PATCH v5 2/2] clk: intel: Add CGU clock driver for a new SoC Message-ID: <20200303100936.GL1224808@smile.fi.intel.com> References: <6148b5b25d4a6833f0a72801d569ed97ac6ca55b.1582096982.git.rahul.tanwar@linux.intel.com> <4fb7a643-cbe1-da82-2629-2dbd0c0d143b@linux.intel.com> <20200227100239.GD1224808@smile.fi.intel.com> <12c16eb0-04aa-79cf-fa76-3f45b8972319@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12c16eb0-04aa-79cf-fa76-3f45b8972319@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 03, 2020 at 11:37:23AM +0800, Tanwar, Rahul wrote: > On 27/2/2020 6:02 PM, Andy Shevchenko wrote: > > On Thu, Feb 27, 2020 at 03:19:26PM +0800, Tanwar, Rahul wrote: > >> On 19/2/2020 3:59 PM, Randy Dunlap wrote: > >>> On 2/18/20 11:40 PM, Rahul Tanwar wrote: > >>> > >>>> +config CLK_LGM_CGU > >>>> + depends on (OF && HAS_IOMEM) || COMPILE_TEST > >>> This "depends on" looks problematic to me. I guess we shall see when > >>> all the build bots get to it. > >> At the moment, i am not able to figure out possible problems in this.. > > COMPILE_TEST should be accompanied by non-generic dependency. > > There is none. > > > > So, I quite agree with Randy. > > I see COMPILE_TEST is mostly ORed with ARCH_xx. How about below? > > depends on OF && HAS_IOMEM && (CONFIG_X86 || COMPILE_TEST) How about to leave logical parts separately? How is OF related to architecture? On top of that, is this code only for x86 for sure? > >>>> + select OF_EARLY_FLATTREE > >>> If OF is not set and HAS_IOMEM is not set, but COMPILE_TEST is set, > >>> I expect that this should not be attempting to select OF_EARLY_FLATTREE. > >>> > >>> Have you tried such a config combination? > >> Agree, that would be a problem. I will change it to > >> > >> select OF_EARLY_FLATTREE if OF > > Nope, I think this is wrong work around. > > See above. > > With above proposed change, i can simply switch to > select OF_EARLY_FLATTREE since all dependencies are already > in place.. Right. -- With Best Regards, Andy Shevchenko