From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: power: apmu: Convert to json-schema
Date: Tue, 3 Mar 2020 13:56:15 +0100 [thread overview]
Message-ID: <20200303125615.GC571445@oden.dyn.berto.se> (raw)
In-Reply-To: <20200221121221.31298-1-geert+renesas@glider.be>
Hi Geert,
Thanks for your patch.
On 2020-02-21 13:12:21 +0100, Geert Uytterhoeven wrote:
> Convert the Renesas Advanced Power Management Unit Device Tree binding
> documentation to json-schema.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../bindings/power/renesas,apmu.txt | 35 ------------
> .../bindings/power/renesas,apmu.yaml | 55 +++++++++++++++++++
> 2 files changed, 55 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/renesas,apmu.txt
> create mode 100644 Documentation/devicetree/bindings/power/renesas,apmu.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/renesas,apmu.txt b/Documentation/devicetree/bindings/power/renesas,apmu.txt
> deleted file mode 100644
> index 5f24586c8cf33fcf..0000000000000000
> --- a/Documentation/devicetree/bindings/power/renesas,apmu.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -DT bindings for the Renesas Advanced Power Management Unit
> -
> -Renesas R-Car and RZ/G1 SoCs utilize one or more APMU hardware units
> -for CPU core power domain control including SMP boot and CPU Hotplug.
> -
> -Required properties:
> -
> -- compatible: Should be "renesas,<soctype>-apmu", "renesas,apmu" as fallback.
> - Examples with soctypes are:
> - - "renesas,r8a7743-apmu" (RZ/G1M)
> - - "renesas,r8a7744-apmu" (RZ/G1N)
> - - "renesas,r8a7745-apmu" (RZ/G1E)
> - - "renesas,r8a77470-apmu" (RZ/G1C)
> - - "renesas,r8a7790-apmu" (R-Car H2)
> - - "renesas,r8a7791-apmu" (R-Car M2-W)
> - - "renesas,r8a7792-apmu" (R-Car V2H)
> - - "renesas,r8a7793-apmu" (R-Car M2-N)
> - - "renesas,r8a7794-apmu" (R-Car E2)
> -
> -- reg: Base address and length of the I/O registers used by the APMU.
> -
> -- cpus: This node contains a list of CPU cores, which should match the order
> - of CPU cores used by the WUPCR and PSTR registers in the Advanced Power
> - Management Unit section of the device's datasheet.
> -
> -
> -Example:
> -
> -This shows the r8a7791 APMU that can control CPU0 and CPU1.
> -
> - apmu@e6152000 {
> - compatible = "renesas,r8a7791-apmu", "renesas,apmu";
> - reg = <0 0xe6152000 0 0x188>;
> - cpus = <&cpu0 &cpu1>;
> - };
> diff --git a/Documentation/devicetree/bindings/power/renesas,apmu.yaml b/Documentation/devicetree/bindings/power/renesas,apmu.yaml
> new file mode 100644
> index 0000000000000000..09328d311d16422f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/renesas,apmu.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/renesas,apmu.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: DT bindings for the Renesas Advanced Power Management Unit
> +
> +maintainers:
> + - Geert Uytterhoeven <geert+renesas@glider.be>
> + - Magnus Damm <magnus.damm@gmail.com>
> +
> +description:
> + Renesas R-Car Gen2 and RZ/G1 SoCs utilize one or more APMU hardware units for
> + CPU core power domain control including SMP boot and CPU Hotplug.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - renesas,r8a7743-apmu # RZ/G1M
> + - renesas,r8a7744-apmu # RZ/G1N
> + - renesas,r8a7745-apmu # RZ/G1E
> + - renesas,r8a77470-apmu # RZ/G1C
> + - renesas,r8a7790-apmu # R-Car H2
> + - renesas,r8a7791-apmu # R-Car M2-W
> + - renesas,r8a7792-apmu # R-Car V2H
> + - renesas,r8a7793-apmu # R-Car M2-N
> + - renesas,r8a7794-apmu # R-Car E2
> + - const: renesas,apmu
> +
> + reg:
> + maxItems: 1
> +
> + cpus:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Array of phandles pointing to CPU cores, which should match the order of
> + CPU cores used by the WUPCR and PSTR registers in the Advanced Power
> + Management Unit section of the device's datasheet.
> +
> +required:
> + - compatible
> + - reg
> + - cpus
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + apmu@e6152000 {
> + compatible = "renesas,r8a7791-apmu", "renesas,apmu";
> + reg = <0xe6152000 0x188>;
> + cpus = <&cpu0 &cpu1>;
> + };
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2020-03-03 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 12:12 [PATCH] dt-bindings: power: apmu: Convert to json-schema Geert Uytterhoeven
2020-03-03 12:56 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303125615.GC571445@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).